Core: Slow performance

[amitguptagwl]

This is really a helpful framework. But when I compared the benchmark report against other frameworks, I found that adonis is not performing well.

https://github.com/PlainSight/NodeRestPerfTest3

Result

Requests per second:    10526.97 [#/sec] (mean)
raw_node
Requests per second:    17931.46 [#/sec] (mean)
restify
Requests per second:    11835.28 [#/sec] (mean)
koa2
Requests per second:    13180.16 [#/sec] (mean)
fastify
Requests per second:    15888.34 [#/sec] (mean)
total.js
Requests per second:    14446.93 [#/sec] (mean)
sails.js
Requests per second:    2016.40 [#/sec] (mean)
adonis.js
Requests per second:    4063.64 [#/sec] (mean)

I'm running tests on Ubuntu 17.10, 16gb RAM, node 9.5

[thetutlage]

U r benchmarking a way older version of AdonisJs

[webdevian]

See more discussion here - https://github.com/adonisjs/adonis-framework/issues/586

[amitguptagwl]

I have reinstalled adonis and it's cli to latest. But unfortunately got Requests per second: 1302.72 [#/sec] (mean) for the same tests.

[thetutlage]

How did you installed the cli?

[amitguptagwl]

I installed https://www.npmjs.com/package/@adonisjs/cli

sudo npm i --global @adonisjs/cli

[thetutlage]

Then please create a slim app using the cli and share a repo with benchmarks

[amitguptagwl]

Here is the forked and updated repo

https://github.com/amitguptagwl/NodeRestPerfTest3

[thetutlage]

The repo still has the old code

[thetutlage]

This is a old file https://github.com/amitguptagwl/NodeRestPerfTest3/blob/master/yardstick-changes/app/Http/routes.js

[amitguptagwl]

Thanks. This time I have --api-only flag to create the repo. And used new route. New score is;

Requests per second: 6475.26 [#/sec] (mean)

[RomainLanz]

You must use the --slim flag if you want to have a realistic comparison between other frameworks. You are still currently comparing orange to apple. 😉

Whatever, I believe this https://github.com/adonisjs/adonis-framework/issues/586 and this https://hueniverse.com/when-500-faster-is-garbage-553121a088c3 should be read.

[amitguptagwl]

I completely agree that if you are providing some features, it'll impact the speed somewhere. and performance doesn't mean speed only.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.