Core: Different Pushover notify instances getting mixed up

[jwater7]

Make sure you are running the latest version of Home Assistant before reporting an issue.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:

Home Assistant release (hass --version):
0.60.0 (nothing appears to have changed in .1)

Python release (python3 --version):
Official docker container

Component/platform:
Pushover notify

Description of problem:
I have multiple pushover notify services set up, and example is in the yaml section below. When I call some of them from either the UI or via an automation, the wrong one (a different service’s configuration, by a different name) gets executed. The message is correct.

I confirmed this was only a problem with HA by executing a command line tool to send a notification with the same api key and it works as expected.

Expected:
The name of the service is mapped to the correct service by the same name (same api key).

Problem-relevant configuration.yaml entries and steps to reproduce:

notify:
  - name: pushoversecurity
    platform: pushover
    # security token
    api_key: key1...
    # all_group
    user_key: ...

  - name: pushoverhome
    platform: pushover
    # home token
    api_key: key2...
    # all_group
    user_key: ...

  - name: pushovermailbox
    platform: pushover
    # mailbox token
    api_key: key3...
    # all_group
    user_key: ...
    #data:
      #sound: none

  - name: pushovertest
    platform: pushover
    # test token
    api_key: key4...
    # test_group
    user_key: ...

  - name: smtpsecurity
...

1. Create multiple pushover notification services with different api keys
2. Execute one of the services
3. It will use an api key from a different service configuration

Traceback (if applicable):

Additional info:
I have a feeling that it has something to do with async or the mapping in async_notify_message in https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/notify/__init__.py but I am not familiar enough with the code or troubleshooting techniques to get more info on it.

[balloobbot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

[jwater7]

I can still reproduce the issue with the latest version 0.66.0. HA didn’t used to have this problem in earlier versions and if I had to guess, the change that broke it might have been from https://github.com/home-assistant/home-assistant/commit/8267a21bfe74520c7c8e0a8e94114476106261d9 by @amelchio which is also still the latest commit for that file. Hope that helps. If you have other ways I can help troubleshoot to narrow the problem down, please let me know.

[jimbob1001]

Just to add this bug still exists in 0.74.1. cannot use multiple pushover apis, as home assistant always uses the first in the list

[amelchio]

This is in fact an error in the third party library, it does not properly handle multiple clients.

A change like Thibauth/python-pushover#27 is needed before Home Assistant can be fixed.

[jwater7]

Thanks for making the change and submitting a pull request to upstream!

[amelchio]

Yeah, tagging an innocent man seems to work out for you in the end ;-)

Anyway, I prepared a Home Assistant PR that you can test right now: #15726. If you follow the instructions at the top, it should use my python-pushover branch with the fix.

[jwater7]

Sorry about that - I was sure it was working in an earlier version so gave it a best guess. Also figured if it wasn’t the problem, you would know :) I’ll check out your PR - and thanks again!

[amelchio]

Don't worry, I'm happy to be tagged.

This time I did know that it could not be related which is why I ignored it for so long. But curiosity prevailed :)

[jhavens12]

This is happening to me on v 0.80.3 - HASS just picks the first pushover instance in the list to use and ignores my preference

[deanrparry]

Not sure any of the devs use it so not likely to see a quick fix... patience is a virtue :)

[amelchio]

Still waiting for upstream Thibauth/python-pushover#27 to get released.

[deanrparry]

You are aware that when using this custom component the sound element does not work yes? example high priority pushover

[amelchio]

Yes, I believe that is fixed with the most recent version of my branch. Here

[deanrparry]

no it does not work with the 0.5

i modified you 0.4 branch with the changes from

https://github.com/amelchio/python-pushover/compare/local-token...ashmckenzie:fixes

and it works fine

think you may have missed them small changes?

[amelchio]

You may have missed that my branch was updated.

[deanrparry]

Guess what I missed ;-) works perfectly! Sincere apologies sir.

[amelchio]

Thanks for testing 👍. I have run out of Pushover trials :-)

[balloobbot]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

[amelchio]

Still waiting for upstream Thibauth/python-pushover#27 to get released.

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[jwater7]

Still not working

[amelchio]

I think we should consider the upstream library abandoned at this time. Apparently PyPI has several other Pushover libraries available, is anyone up for finding a suitable replacement?

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[jwater7]

Nope, still not working

[jwater7]

NOTICE: Now that Apprise is available (https://www.home-assistant.io/integrations/apprise/) I've migrated my automatons to use the new apprise notify service (using the pushover/pover URL) and I no longer have this issue.

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[sagitt]

no solution for this?