Core: badIndex in Native/Json.js defined twice
The function badIndex is defined twice in the file Native/Json.js:
The definitions are identical.
This isn't a problem for JavaScript, but causes Closure Compiler to barf:
JSC_BLOCK_SCOPED_DECL_MULTIPLY_DECLARED_ERROR: Duplicate let / const / class / function declaration in the same scope is not allowed. at line 6664 character 9
function badIndex(index, nestedProblems)
mzero
All 3 comments
Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!
Here is what to expect next, and if anyone wants to comment, keep these things in mind.
process-bot
on 12 Jan 2018
This got fixed in the dev branch so will be included in the next release of elm-lang/core. Thanks for logging the issue!
zwilias
on 12 Jan 2018
It is cool that this bug has been fixed for Elm 0.19, but there are a lot of people still using Elm 0.18 because 0.19 has not been released yet! Is there a process for backporting the fix to the 5.1 version of this library (I will do all the work)? Looking at the git history, it does not look like release branches are being used, is there opposition to creating one from the 5.1.1 tag? I could then cherry pick the badIndex fix onto it, and a member could release a 5.1.2 bugfix for all Elm users in ~5 minutes.
YetAnotherMinion
on 28 Apr 2018
Related issues
rtfeldman
路
8Comments
RobertWalter83
路
4Comments
rtfeldman
路
3Comments
malaire
路
6Comments
zzz6519003
路
4Comments
Most helpful comment
It is cool that this bug has been fixed for Elm 0.19, but there are a lot of people still using Elm 0.18 because 0.19 has not been released yet! Is there a process for backporting the fix to the 5.1 version of this library (I will do all the work)? Looking at the git history, it does not look like release branches are being used, is there opposition to creating one from the 5.1.1 tag? I could then cherry pick the badIndex fix onto it, and a member could release a 5.1.2 bugfix for all Elm users in ~5 minutes.