Core: Add oc:privatelink PROPFIND property for files on old and new dav endpoints

[PVince81]

Define a new property "oc:privatelink" that returns the private link as generated in the share panel.

• Use the IURLGenerator and the proper route and pass in the file id.
• Most of the code should live in the FILES_PLUGIN.
• The property must be protected (read-only).

[michaelstingl]

Related:

• https://github.com/owncloud/client/issues/6020
• https://github.com/owncloud/android/issues/2032
• https://github.com/owncloud/ios/issues/938

[PVince81]

Also add a capabilitiy:

• [ ] add oc:privatelink property in FilesPlugin + unit tests
• [ ] add capability

[michaelstingl]

Just to be sure: Link generated with new method will be used in web UI too?

[PVince81]

The web UI could be rewired to use this property, yes. Not sure if needed though.

[michaelstingl]

It would be cool, if private link from web UI also would respect settings from config.php, like 'overwritehost' etc…

[PVince81]

@michaelstingl I think it should already as it should be using the URL generator from JS.

Let's double check this anyway:

• [ ] make sure web UI uses the same / a similar mechanism to make sure overwritehost is taken into account

@michaelstingl did you observe any cases where said link did not ? That would be a bug...

[michaelstingl]

did you observe any cases where said link did not

Never tested - I only found links generated in clients showed different behaviour.

[IljaN]

I can only find a "Public-Link" in the Ui is it the same?

[PVince81]

looks like you found it 😄

can you also extend the capabilities to say something like "privateLinks => true" ?

[PVince81]

and add a unit test...

[IljaN]

Request:
PROPFIND http://localhost:8000/remote.php/dav/files/admin/foo/zubulski.txt

<?xml version='1.0' encoding='utf-8'?>
<propfind xmlns="DAV:">
  <prop>
    <privatelink xmlns="http://owncloud.org/ns"/>
  </prop>
</propfind>

Response:

<?xml version='1.0' encoding='UTF-8'?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns"
xmlns:cal="urn:ietf:params:xml:ns:caldav" xmlns:cs="http://calendarserver.org/ns/"
xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/dav/files/admin/foo/zubulski.txt</d:href>
    <d:propstat>
      <d:prop>
        <oc:privatelink>http://localhost:9090/index.php/f/22</oc:privatelink>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

[michaelstingl]

@ckamm @SamuAlfageme @davivel @jesmrec Could you provide a quick feedback if @IljaN 's approach works for you?

[jesmrec]

works for me

[ckamm]

works for me as well

[felixboehm]

@michaelstingl works for you and all three clients?
Otherwise reopen please.

[michaelstingl]

@felixboehm If it works for @jesmrec and @ckamm , it works for me too 😄

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.