Core: limitless light scene definition does not work if transition is present

[janLo]

Home Assistant release (hass --version): 0.39.1

Python release (python3 --version): 3.4.2

Component/platform: light/limitlessled

Description of problem:
If a scene definition for a limitless lightgroup contains a transition the limitless code throws an exception as it gets None somewhere in the transition as color. This worked in 0.38.1.

Expected:
The transition should be executed as defined.

Problem-relevant configuration.yaml entries and steps to reproduce:

group:
  - name: XYZ
      light.xxx:
        state: on
        transition: 1
        rgb_color: [236,92,0]
        brightness: 23

Traceback (if applicable):

Exception in thread Thread-17:
Traceback (most recent call last):
  File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner
    self.run()
  File "/home/hass/.homeassistant/deps/limitlessled/pipeline.py", line 32, in run
    self._queue.get().run(self._event)
  File "/home/hass/.homeassistant/deps/limitlessled/pipeline.py", line 109, in run
    self._execute_stage(i, stage, stop)
  File "/home/hass/.homeassistant/deps/limitlessled/pipeline.py", line 167, in _execute_stage
    self._group.transition(*stage.args, **stage.kwargs)
  File "/home/hass/.homeassistant/deps/limitlessled/group/rgbw.py", line 129, in transition
    self._transition(duration, hue_of_color(color), brightness)
  File "/home/hass/.homeassistant/deps/limitlessled/util.py", line 15, in hue_of_color
    return rgb_to_hsv(*[x / 255 for x in color])[0]
TypeError: 'NoneType' object is not iterable

[janLo]

Seems to be a limitlessled bug: https://github.com/happyleavesaoc/python-limitlessled/issues/11

[Morton16ok]

I am having the same issue since upgrading to 0.39.1.

[janLo]

The fix in python-limitlessled is merged with https://github.com/happyleavesaoc/python-limitlessled/pull/12. All it needs is a bugfix-release of limitless and one for HA that bumps the dependency. For now you can apply the patch manually: https://github.com/happyleavesaoc/python-limitlessled/commit/2e30184e195d3788fa85c21e147df347c9539ed6.patch

[adifoto]

Can you please explain, for some of us that are not coders how can this be fixed.
My automation will not start at sunset and my lights will be at 50% intensity and will get stack can't turn them off or change it until i restart everything.
There is no error in the log about limitles led.
For the moment i took the transition off.
I had a look at the github in above post but have no idea what to do.
Any help is much appreciated.
Thanks

[janLo]

I hope it will be fixed within 0.39.2. Until this either drop the transition or go to your limitlessled lib (probably installed at ~/.homeassistant/deps/limitlessled and apply the patch:

curl https://github.com/happyleavesaoc/python-limitlessled/commit/2e30184e195d3788fa85c21e147df347c9539ed6.patch | patch -p2

I recommend to wait, as the fix is already done and just need to be merged.

[Meganoodle]

I am also having the same issue, I have hashed out the transitions as suggested, not sure if it has made a difference yet.

[adifoto]

Taking of transition should do the trick (mine works now) anyway some suggested that the new version should fix the problem just updated the other day to 0.39.3 but deed not have time to see if is fixed or not. what version do you have?

[Morton16ok]

I updated to 39.3 and my transitions still didn't work so I added the patch
@Jan posted. Everything works for the most part but if I set a bulb to
flash with a transition it still gets stuck, otherwise, with the patch,
they're working fine.

On Sun, Mar 5, 2017, 6:27 AM adifoto [e-mail] wrote:

Taking of transition should do the trick (mine works now) anyway some
suggested that the new version should fix the problem just updated the
other day to 0.39.3 but deed not have time to see if is fixed or not. what
version do you have?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/6295#issuecomment-284221618,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADhODAjw6wgoxOX0GI3ZR0ZJmO_EFzwgks5ripwFgaJpZM4MNqPT
.

[janLo]

As the releasenotes for 0.39.3 does not mention it, I think the version-bump was forgotten in this release. Maybe the next bugfix-release or at least 0.40 should have it as its already merged.

[adifoto]

I can confirm that 39.3 deed not fix the problem with the transitions. Until it is fixed i will take the transition off, hope the next update will fix it.

[adifoto]

All works fine now with 40.0 Thanks for all the hard work.