Core: Commit #3783 in Dev broke the Automation platform for my configuration

[tylerstraub]

Commit #3783 on the Dev branch has prevented the HaSS service from launching for me.

I get:

"The following platforms contain invalid configuration: automation"

Repeated in the log file on service start.

This is how the automation portion of my config is constructed:

# INCLUDE DIR
automation: !include_dir_list automation
automation location-actions: !include_dir_list automation/location-actions
automation location-actions-lighting: !include_dir_list automation/location-actions/location-actions-lighting
automation location-notices: !include_dir_list automation/location-notices
automation lighting-actions: !include_dir_list automation/lighting-actions

I thought it may have been something to do with multiple inclusions, so I attempted commenting out all but the first and the service still produced the same errors.

Beyond this, I haven't had time to troubleshoot further. The issue may be specific to the use of !include_dir_list automation, or perhaps something deeper like having subfolders in your automation directory path.

Will report back more detailed information if I have time to continue investigation.

Thanks!

[kellerza]

You should only need the first line.

Do you mind posting a full tree of all files under this directory?

[lwis]

@tylerstraub as @kellerza mentioned - it would be good to see tree executed at the root of automation.

However, subfolders shouldn't matter here - it will simply recurse into them and pick them up as if they were all on one level, atleast that's what I saw in the tests.

[tylerstraub]

@kellerza @lwis no problem! Thanks for the help!

fyi: I am currently using a pattern of creating a folder named "disabled" to store scripts that were either unused, broken or not needed to avoid deletion of work that I may build upon later. Maybe these scripts are now being passed into the compiler with the recent change?

hass@KUMA-NOOMISO:~/.homeassistant/automation$ tree
.
├── disabled
│   ├── owntracks_refresh.yaml
│   └── template_test.yaml
├── lighting-actions
│   └── disabled
│       ├── bedroom_bulb.yaml
│       ├── bedroom_desk_lamp.yaml
│       ├── bedroom_mirror_lightstrip.yaml
│       ├── frontroom_lights_default.yaml
│       ├── kitchen_paper_lantern.yaml
│       ├── kitchen_sink_bulb.yaml
│       ├── living_room_bloom_left.yaml
│       ├── living_room_bloom_right.yaml
│       ├── makeup_station_bulb.yaml
│       └── piano_lamp.yaml
├── location-actions
│   ├── arm_stereo.yaml
│   ├── disable_arrival_trigger.yaml
│   ├── location-actions-lighting
│   │   ├── all_lights_default_on_sunset.yaml
│   │   ├── all_lights_dimmed_at_time.yaml
│   │   ├── polerbear_preslight_off.yaml
│   │   ├── polerbear_preslight_on.yaml
│   │   ├── shirokuma_preslight_off.yaml
│   │   └── shirokuma_preslight_on.yaml
│   ├── power_off_on_not_home.yaml
│   ├── set_arrival_trigger.yaml
│   ├── shirokuma_leaves_morning.yaml
│   ├── trigger_authorized_arrival.yaml
│   └── trigger_unauthorized_arrival.yaml
├── location-notices
│   ├── motion_notice.yaml
│   ├── polerbear_enters_home.yaml
│   ├── polerbear_enters_round1.yaml
│   ├── polerbear_leaves_downtown_la.yaml
│   ├── polerbear_leaves_home.yaml
│   ├── polerbear_leaves_metro.yaml
│   ├── shirokuma_enters_home.yaml
│   ├── shirokuma_leaves_csulb.yaml
│   ├── shirokuma_leaves_home.yaml
│   └── shirokuma_leaves_tlc.yaml
├── okinasai_actions.yaml
├── okinasai_trigger_end.yaml
├── okinasai_trigger_sleepin.yaml
├── okinasai_trigger.yaml
├── oyasumi_actions.yaml
├── zwave_heal.yaml
└── zwave_reset.yaml

[lwis]

@tylerstraub Thanks! That's exactly what happening, all of those scripts ending in .yaml will be loaded - could you try moving/renaming any scripts that are in disabled folders?

@kellerza Maybe we should consider adding an exclusion for 'disabled' or . directories?

[tylerstraub]

Sure, I will give that a try when I have a moment to pause from work and report back.

@kellerza some means of folder exclusion would be really useful for ease of workflow in some cases.

[tylerstraub]

@lwis that did it!

Removing the disabled folders from the automation tree and eliminating all but the single automation definition from my Config.yaml brought everything back online with the latest HEAD.

Cheers! Thanks again.

[kellerza]

You cant have configurable exclusion though.

Suggest exclusions based on folders and files starting with . and _. For Windows users . is a pita, and Linux users understand .

Edit: on second thought, simply chaning the extention to not be .yaml should be good enough. Say .badyaml or .disabled