Core: Port Dropbox external storage to the new API

[PVince81]

The old Dropbox API is deprecated https://blogs.dropbox.com/developers/2016/06/api-v1-deprecated/ and will be killed by Dropbox on 28. June 2017.

This means the external storage plugin needs to be ported to the new API.

According to ownCloud's EOL timeline https://github.com/owncloud/core/wiki/Maintenance-and-Release-Schedule, at this time the oldest supported ownCloud version would be 9.0.x

Ideally, the porting should be done in a separate repository "files_external_dropbox" instead of core (as per https://github.com/owncloud/core/issues/18160.

Not sure about OC < 9.2, maybe need to backport the change there.

Thoughts ? @DeepDiver1975

[PVince81]

I just remembered that we wanted to look into porting more storages over to flysystem: https://github.com/thephpleague/flysystem

But flysystem will have the same problem: https://github.com/thephpleague/flysystem-dropbox/issues/14

In general we could maybe write a generic flysystem storage adapter which would make it possible to plug in any of the supported flysystem ones, including the new dropbox adapter if it ever gets written.

[karakayasemi]

There is no official Dropbox v2 SDK and Dropbox said that they do not have plan to release official v2 api, related thread here: https://www.dropboxforum.com/t5/API-support/PHP-SDK-for-API-v2/m-p/173491/highlight/true#M6700

Because of that, flysystem do not have plan to port dropbox v1 adapter to v2.

In @PVince81 GSOC 2017 Dropbox v2 integration project road map, we are planning to port Flysystem Dropbox v1 adapter to v2. If we Port Flysystem Dropbox v1 adapter to v2, which community version of Dropbox v2 SDK will be used?

[PVince81]

With API you mean what SDK to use ? This is to be discussed / cleared out here https://github.com/thephpleague/flysystem-dropbox/issues/14

It should use one of the community SDKs then: https://github.com/thephpleague/flysystem-dropbox/issues/14#issuecomment-281112999

[Hemant-Mann]

Hello @PVince81 I would like to work on this project as a part of GSOC. I have successfully setup the owncloud development environment as described by you here

I have also started writing the flysystem-dropbox adapter v2-Adapter using one of the community SDK Dropbox SDK

[PVince81]

PR to remove Dropbox v1 storage from core: https://github.com/owncloud/core/pull/28073

Note that the new app is a complete rewrite that uses flysystem so there is no need to keep the old code.

[individual-it]

using this SDK https://github.com/kunalvarma05/dropbox-php-sdk for an other project of mine. Works great and I can recommend it

[Hemant-Mann]

@individual-it I have been working on this as a part of GSoC'17. As discussed with my mentor @butonic a new files_external dropbox will be developed based on the lines of Files External FTP using flysystem. Current project progress can be seen here. And I am indeed using this https://github.com/kunalvarma05/dropbox-php-sdk

[individual-it]

Just a quick info: Dropbox extended the Dropbox API v1 deprecation timeline. The new date is September 28th, 2017 https://blogs.dropbox.com/developers/2017/06/updated-api-v1-deprecation-timeline/

[PVince81]

Thanks, but we should still get moving quickly

[lefherz]

@Hemant-Mann I'm writing a https://central.owncloud.org post tomorrow, to inform the community of the v1 API EOL, and that you're writing a new app for this. Can I say that you are happy about contributions?

[Hemant-Mann]

Hey @lefherz I guess as part of GSoC i'll have to code the app but I'll be happy for suggestions, code reviews, any potential bugs that may be there in the code.

[stuckj]

Ah. This explains why dropbox just stopped working for my installation. Looks like the deadline was passed.

[phil-davis]

@stuckj have a look at https://github.com/owncloud/files_external_dropbox
v1.0.0 release was tagged a few days ago:
https://github.com/owncloud/files_external_dropbox/releases/tag/v1.0.0

[sbrl]

Would that work with nextcloud?

[lefherz]

The app is not written to work with nextcloud, I recommend to use it with ownCloud.

[pmaier1]

Reference to ownCloud marketplace for official release: https://marketplace.owncloud.com/apps/files_external_dropbox
Closing here.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.