Core: Saving a model using a command does not terminate

[francisjed]

I was trying to insert a user to users table and it was successful but the command does not terminate after yield user.save(). I think the iterator is in infinite loop.

Model:

'use strict'

const Lucid = use('Lucid')

class User extends Lucid {

}

module.exports = User

Command:

'use strict'

const Command = use('Command')
const User = use('App/Model/User')

class CreateUser extends Command {

  get signature() {
    return 'createUser {userName}'
  }

  get description() {
    return 'This will create and insert a user to DB'
  }

  * handle(args, options) {

    const user = new User()
    user.username = args.userName
    yield user.save() // Success, but wont terminate after this line
  }
}

module.exports = CreateUser

[thetutlage]

Database connections are long lived connections and you are required to close them manually. For ace commands you can do

const Database = use('Database')

* handle(args, options) {

    const user = new User()
    user.username = args.userName
    yield user.save() // Success, but wont terminate after this line
    Database.close()
  }

[francisjed]

@thetutlage Thanks for the fast reply! :)

[thetutlage]

Closing 😄

[lmj0011]

Would be nice to have a caveat or something in the docs related to this
http://adonisjs.com/docs/3.2/interactive-shell#_creating_your_first_command

[3dd13]

just want to add a note here in case others having the issue even after Database.close()

in my case, I also need closing Redis connections because my ace command is writing to Redis as well

// v3
yield use('Redis').quit('default')

[LordZombi]

I've got similar problem but with Mail. I'm sending notification emails using SMTP driver. Mails are sent but the command does not terminate. Any help please?

[3dd13]

make sure all the external connections (e.g. database, redis) are all
explicitly closed

On Wed, 12 Dec 2018 at 8:42 PM, Zombi [e-mail] wrote:

I've got similar problem but with Mail. I'm sending notification emails
using SMTP driver. Mails are sent but the command does not terminate. Any
help please?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/adonisjs/adonis-framework/issues/227#issuecomment-446574969,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANpQ1qQ7F9GLeVrK84Goxnc1OBpapDGks5u4PmwgaJpZM4JW71D
.

[LordZombi]

I do. I saw Databse.close() in doc example, so I close the Database like mentioned but Mail is what makes problems. I'm sending email after query - when I use Mail.fake() its OK but after Mail.send() command is not terminated I was looking for some "Mail.close()" but no success.

[3dd13]

@LordZombi

TL;DR

Mail.connection()._driverInstance.transporter.close()

my troubleshooting steps

• able to repeat with latest adonis version 4.1
• then I look for places that has running connections, where I found SMTPPool
• then I look for places that I can close

underlying source code references

• https://github.com/adonisjs/adonis-mail/blob/2494fd6d6c37198897cb5bdbb1b1b792278c85c2/src/Mail/index.js#L104
• https://github.com/adonisjs/adonis-mail/blob/develop/src/Mail/Sender.js#L24
• https://github.com/adonisjs/adonis-mail/blob/2494fd6d6c37198897cb5bdbb1b1b792278c85c2/src/Mail/Drivers/Smtp.js#L32
• https://github.com/nodemailer/nodemailer/blob/33b62e2ea6bc9215c99a9bb4bfba94e2fb27ebd0/lib/smtp-pool/index.js#L122

[LordZombi]

@3dd13 thanks for the workaround it works!

But I think Adonis can make nicer implementation :) This is kind oh hack when working with private variables (_driverInstance)

Still big thanks.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.