Core-js: ie11 Out of stack space w/ minimal repro

Created on 19 Feb 2020  路  2Comments  路  Source: zloirock/core-js

Affects the latest [email protected]

Importing get-own-property-symbols before core-js web.dom-collections.iterator causes a stack overflow in ie11. get-own-property-symbols is included in webcomponentsjs polyfills, so anyone trying to use core-js with webcomponents polyfills will most likely run into this stack overflow.

I can open this issue against get-own-property-symbols too if you think the issue is on their end.

Minimal repro: https://github.com/bschlenk/ie11-corejs-stack-overflow-repro

Most helpful comment

it's very difficult to make a symbol polyfill/sham/shim that works with another symbol-based feature that is polyfilled, such as is the case you are describing.

I would advise to try and use the symbol polyfill provided by core-js and not the get-own-property-symbols one if at all possible.

All 2 comments

it's very difficult to make a symbol polyfill/sham/shim that works with another symbol-based feature that is polyfilled, such as is the case you are describing.

I would advise to try and use the symbol polyfill provided by core-js and not the get-own-property-symbols one if at all possible.

What I don't understand is, don't most polyfills first do a check to see if the polyfill needs to be added? If I already have Symbol polyfilled, then why isn't this triggering that check? I'm okay with a workaround for now, but this issue gets brought up time and time again (https://github.com/zloirock/core-js/issues/735, https://github.com/zloirock/core-js/issues/686, https://github.com/zloirock/core-js/issues/545, https://github.com/zloirock/core-js/issues/463, https://github.com/zloirock/core-js/issues/387, https://github.com/zloirock/core-js/issues/143) and closed without a real resolution. I figured providing a super minimal repro would be helpful.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ajbowler picture ajbowler  路  3Comments

yusidi picture yusidi  路  3Comments

devongovett picture devongovett  路  4Comments

RedHatter picture RedHatter  路  5Comments

mryellow picture mryellow  路  6Comments