Cookie-autodelete: Cookies in containers are deleted restarting the browser

[captainepoch]

Describe the Bug/Feature

When a host in a container is whitelisted to not delete its cookies, and the browser get restarted (user closes it), cookies are deleted and you have to login again.

Steps for anyone to reproduce the bug

1. Open a container, put an URL, mark it as "Always open in [CONTAINER NAME]".
2. In Cookie AutoDelete, mark it as whitelisted (*.url.com, or url.com, it doesn't matter).
3. Close the browser and open it again.
4. Go to that URL (opening the container).
5. The cookie should be gone.

Your settings

• [X] Enable Automatic Cleaning? Delay Before Cleaning: 0 Minute(s)
• [X] Log Total Number Of Cookies Deleted
• [x] Show Number of Cookies for that Domain
• [ ] Show Notification After Cookie Cleanup
• [ ] Clean Cookies from Open Tabs on Startup

• [X] Enable Support for Firefox's Container Tabs

• OS/version: ArchLinux (updated up to 20171013)

• Browser/version: FF 57 B7
• Cookie AutoDelete version: 2.0.0

[vincekd]

Also seeing this on FF 57 B7 Ubuntu

[pwd-github]

It's not just cookies in containers. Every time the browser starts, CAD is flushing cookies.

[ke-d]

I'm looking into this but so far haven't been able to reproduce. Maybe something to do with the migration of settings/lists?

Could try just deleting or renaming storage.js in browser extension data and seeing if the problem exists in a clean state of C-AD.

[gwarser]

I have similar problem on mobile. Every time extension starts, cookies are deleted. It's enough to go to about:addons and disable -> enable. This happens even when I remove it, and then install again. Restoring default settings did not help, beside this - in webextensions setting should be deleted when extension is removed.
This started on update from beta to stable.

[pwd-github]

This is actually an issue on all of my devices, one tablet, one phone and my laptop, all running Nightly.

[ke-d]

Can you guys test which beta version did the issue started happening?

https://addons.mozilla.org/en-US/firefox/addon/cookie-autodelete/versions/beta

[pwd-github]

I never had an issue before the UI changed, so latest version. 

1. Oct 2017 02:44 by [email protected]:

>

Can you guys test which beta version did the issue started happening?

https://addons.mozilla.org/en-US/firefox/addon/cookie-autodelete/versions/beta

—
You are receiving this because you commented.
Reply to this email directly, > view it on GitHub> , or > mute the thread> .

[captainepoch]

@pwd-github Yes, that's true, even in default mode.

@mrdokenny I have this issue since the first version that supported containers, even with 2.0.0 stable.

[ke-d]

I have this issue since the first version that supported containers, even with 2.0.0 stable.

Are you sure you are not confusing it with the normal function though?

https://github.com/Cookie-AutoDelete/Cookie-AutoDelete/blob/2.X.X-Branch/src/background.js#L253

Basically on startup, cookie cleanup occurs this time cleaning cookies from the grey lists. I made this table that explains it better.

| |Cookies that don't correspond to an open tab|Cookies that correspond to an open tab|GreyList|WhiteList|
|---|:---:|:---:|:---:|:---:|
|Normal Cleanup|X| | | |
|Cleanup, include open tabs|X|X| | |
|Startup cleanup|X| |X| |
|Startup cleanup with "Clean Cookies from Open Tabs on Startup"|X|X|X| |

[vincekd]

Would the browser setting for cookie management affect this? Should I have the setting to keep cookies until they expire?

[captainepoch]

@mrdokenny I whitelisted every cookie I want to stay, within or not inside a container. The rest of the cookies are not whitelisted or are greylisted.

So, for example, in "Default" I got DuckDuckGo.com, and I got a "Twitter" container. Those two cookies are whitelisted. So, everytime I open Firefox, those cookies shouldn't be cleaned, right? As I understand from the table. Well... They got cleaned.

@vincekd behaviour doesn't change with that, I tried

[gwarser]

1.4.0b5 is good
2.0.0b1 is bad

(Why no beta tags in repo or commit hashes in AMO version history?)

[pwd-github]

I just updated my secondary profile from 1.4.3 to 2.0.0 and the issue started happening there too.

[ke-d]

(Why no beta tags in repo or commit hashes in AMO version history?)

I delete them after a while to prevent clutter.

1.4.0b5 is good
2.0.0b1 is bad

Well, this is a problem since 1.X.X -> 2.X.X are vastly different than each other. I rewrote most of the core functionality codebase in 2.X.X to support expressions such as wildcards.

Feel free to send me your storage.js privately through email so I can take a look.

[gwarser]

You are calling cookieCleanup inside onStartUp without checking if Active Mode is really enabled.
(I may be wrong - 3am here :) )

We may have here 2 or 3 mixed issues. Mine is: cookies are cleaned on startup, when active mode disabled, on clean Firefox profile.

[ke-d]

We may have here 2 or 3 mixed issues. Mine is: cookies are cleaned on startup, when active mode disabled, on clean Firefox profile.

I know @pwd-github uses the manual mode so that's probably his problem as well.

I think @captainepoch might have a different problem.

For now, I can fix that problem and see what happens. Thanks for catching that @gwarser

[chiraag-nataraj]

I've actually only had this problem once, when I closed Firefox by force (using kill), which meant it started up with about:sessionrestore or whatever, leading to all of my cookies being cleared.

[ke-d]

Closing for inactivity.