Cookie-autodelete: Don't change the icon color when the badge is visible
This is a solution proposal to some of the issues raised in #66. Changing the icon color gives useful feedback when there is no badge (#4) but it seems redundant to do this when the badge is visible. Since the badge matches the icon color, there is no contrast between the two and they merge into an ugly blob of color. Retaining the original icon color when the badge is enabled preserves the integrity of the logo and makes it more recognizable without sacrificing feedback.
nkestrel
All 6 comments
Generally I use upvotes/comments to gauge the interest of a feature. So I'll see what other people think since it's a visual tweak.
ke-d
on 30 Jun 2017
@nkestrel You did that in code or is that just a mockup?
ke-d
on 1 Jul 2017
Why not use a fixed badge color and keep changing the icon color? Use black for the badge. On my system, in Chrome, the badge is tiny, we see more of the icon than the badge...
B00ze64
on 1 Jul 2017
@mrdokenny I just renamed the icons. 馃槒
nkestrel
on 2 Jul 2017
As a point of reference, I have 3 other add-ons with counter badge overlays. They all use the fixed-badge-color idea as @B00ze64 suggested. One is black, one is grey, and one matches the icon (and thus has the same low-contrast issue).
drcheap
on 21 Nov 2017
If you would like to give it a try, head on over to PR #713 and download the latest build (in comments) and let me know if there's any tweaks that need to be looked into.
kennethtran93
on 7 May 2020
Related issues
gwarser
路
7Comments
AtomicRobotMan0101
路
3Comments
dacav
路
7Comments
frankclaassens
路
4Comments
imtbl
路
4Comments
Most helpful comment
Why not use a fixed badge color and keep changing the icon color? Use black for the badge. On my system, in Chrome, the badge is tiny, we see more of the icon than the badge...