Conversations: Use newly introduced notification channels

[harshitbansal05]

Since from api level 26, NotificationCompat.Builder(Context context) is deprecated, I think it would be better to use notification channels, introduced in Android O. They would give us the ability to group notifications into groups and at the same time make it easy for user to manage notification channels.

[iNPUTmice]

There is already a pull request for this. But I currently don’t know enough about notification channels to properly review it.

[licaon-kter]

This would be nice. Eg. Put the useless "Conversations is running Touch to open" that you are forced to have with Foreground service in a "service" channel and then hide only that since you can control visibility per channel.

[daivat15]

@licaon-kter are you sure foreground services can be hidden from the notification bar? The whole point of having a foreground service is to keep the user and the Android system actively aware that such a service is running. Hiding it will destroy the whole point. It is a really good idea, but are you sure Android allows this?

[licaon-kter]

No, these are not exclusive. The notification is there because Android forces you, but it allows you to hide notifications.

[daivat15]

@licaon-kter I did some research. I believe this is allowed only after Android 8.1 (API 27). Am I right?

[licaon-kter]

The channels yes, the hiding is there since 5.0, albeit you'll hide new messages notifications dn Conversations case then.

[daivat15]

@licaon-kter I think we can hide the notification when the app is writing logs also. What say?

[licaon-kter]

What does that mean exactly? On "Export logs"? If yes, how often do you do that?

[iNPUTmice]

The export log notification is used to track the progress. Hiding that
would be problematic

On Mar 16, 2018 14:22, "Licaon_Kter" [e-mail] wrote:

What does that mean exactly? On "Export logs"? If yes, how often do you do
that?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/siacs/Conversations/issues/2875#issuecomment-373711557,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALu5RVeCr301y0wDotwsguN2hsik7cWks5te7ysgaJpZM4Sp6Aj
.

[daivat15]

@iNPUTmice Noted thanks!

[iNPUTmice]

has been implement in 2.3.0