Content: Issue with "Recording a media element": (short summary here please)

Created on 24 Mar 2021  ·  7Comments  ·  Source: mdn/content

MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/MediaStream_Recording_API/Recording_a_media_element

What information was incorrect, unhelpful, or incomplete?

in the result, section the link "take a look at all the code" links to

https://yari-demos.prod.mdn.mozit.cloud/en-US/docs/Web/API/MediaStream_Recording_API/Recording_a_media_element/_samples_/Example

Specific section or headline?

Result

What did you expect to see?

link to the code

Did you test this? If so, how?



MDN Content page report details

10 minute task Media P2 help wanted

All 7 comments

To whoever fixes this issue, it looks like the following is needed:

  • Make sure 'take a look at all the code link' under the Result header links to the source code
  • Keep the link to the demo, but label it correctly e.g 'here is the code running'

Hi @Rumyra, I've to keep the link same but change the label from"take a look at all the code" to "here is the code running". This is my understanding of your comment. Please correct me if I'm wrong.

Yes @nayaldivya - we usually have two links: One to the source code and one to the working demo.

A good example is here https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Using_Web_Audio_API - underneath the first image of the boombox there's a 'Check out the demo' link _and_ 'see the source code'.

Applying something similar to the above page would solve the issue and improve 👍

Hi @Rumyra, sorry for disturbing again but I didn't find any repository containing the code mentioned in the issue. Can you please help me with it.

My apologies @nayaldivya I have dug into this a bit further and I think my instructions were misleading. The demo is being generated from the code within the page, rather than held in a separate repository.

While I do think that demo should be in the dom-examples repo https://github.com/mdn/dom-examples - I also think that's out of scope for this issue.

Instead I would change the line in question to:

<p>You can {{LiveSampleLink("Example", "view the full demo here")}}, and use your browsers developer tools to inspect the page and look at all the code, including the parts hidden above because they aren't critical to the explanation of how the APIs are being used.</p>

I hope that helps :)

Thank you so much @Rumyra for the guidance.

Thank _you_ so much @nayaldivya for your help 🙌

Was this page helpful?
0 / 5 - 0 ratings