Content: We should decide on a label where admin's merge is required?
There have been a lot of PRs that have touched many codeowners' files. I believe (not 100% sure) each team needs to approve to get the PR greenlight which is practically not possible. Some discussions on this led to the decision that admins will merge those PRs once one or two reviewers approve.
I was thinking that we should decide on a label that we can put on PRs that are ready to merge but needs admin's power...? It will make it easy for admins to sort the PRs with that label. I propse a label on the lines: admin merge required.
Example: https://github.com/mdn/content/pull/450.
PS: any thoughts on using help-wanted labels on issues to attract some more outside contribution?
cc @chrisdavidmills @peterbe @sideshowbarker.
vkWeb
All 6 comments
Good idea @vkWeb. I'm happy with admin merge required if everyone else is.
chrisdavidmills
on 21 Dec 2020
Good idea @vkWeb. I'm happy with
admin merge requiredif everyone else is.
Works for me (and thanks @vkWeb for taking time to propose it)
sideshowbarker
on 21 Dec 2020
Cool, I've got a second, and the label has been made, so let's close this. Thanks folks!
chrisdavidmills
on 21 Dec 2020
Now we just need to learn to remember it :)
peterbe
on 22 Dec 2020
@peterbe yeah :laughing:
vkWeb
on 22 Dec 2020
Btw, thanks everyone for agreeing on this! :tada:
vkWeb
on 22 Dec 2020
Related issues
chunkybanana
路
3Comments
Elchi3
路
4Comments
rachelandrew
路
4Comments
yukulele
路
4Comments
jakseb
路
3Comments
Most helpful comment
Now we just need to learn to remember it :)