Contacts: Saving reverts changes which happened during the save.

[RobertZenz]

When editing a contact the contact is being automatically saved when you stop typing. Any changes you make during the saving process (the spinner is visible in the right upper corner) are being reverted the moment saving is completed.

This is especially bad when you, for example, type in a phone number while reading it from a different source. You start typing, then look at the source and this pause causes the save, so there's a chance that you'll start typing during the save and any input you've done during the saving process will be reverted, potentially leaving you with a partially filled in field.

Steps to reproduce the behavior

1. Open a contact.
2. Start typing in an input field, stop for a few seconds and begin typing as soon as the saving starts.

When saving finishes, everything you've typed during the saving will be reverted.

Expected behavior

Changes the user put into the field should never be silently reverted.

Actual behavior

They are silently reverted when the save finishes.

Note

It for sure is my server who is not as fast as a server could be, but this hasn't been a problem until the upgrade to 15.

[nextcloud-bot]

GitMate.io thinks possibly related issues are https://github.com/nextcloud/contacts/issues/314 (Saved searches), https://github.com/nextcloud/contacts/issues/616 ([Vue] Save groups on change), https://github.com/nextcloud/contacts/issues/559 (Changes not saved), https://github.com/nextcloud/contacts/issues/562 (Changes not saved on Contacts), and https://github.com/nextcloud/contacts/issues/533 (Changes are not saved).

[skjnldsv]

Hello @RobertZenz :)

Thanks for your report. I'm guessing you're on contacts 3.0.x?

[RobertZenz]

Exactly, 3.0.3 to be exact.

[skjnldsv]

@RobertZenz thanks.
I cannot reproduce. Every change I do are still sent to the server and kept as it is :/

As you can see (I enabled bandwidth limiter), multiple save doesn't change the edits I do to the contact.

[RobertZenz]

I could not clearly see whether you were typing while the saving was in progress. Can I do something to debug this on my end?

[skjnldsv]

@RobertZenz I'll try with an even longer bandwidth multiplier.
This happens when you use your phone, right?

[skjnldsv]

@RobertZenz Okay I was able to reproduce the issue just now!

[RobertZenz]

Glad to hear that you could reproduce it.

Well, in my case it is not the bandwidth of the connection, it is my server directly. I'm using an oldish (10 years approaching Atom) as my main server, which is quite fast enough for the two users it needs to serve to. But from time to time it lacks a little.

[raimund-schluessler]

@skjnldsv How do I enable bandwidth limiter? I would like to test it with Tasks as well.

[skjnldsv]

@raimund-schluessler on the network tab of your dev tools, you can set various speed limits :)

[jaller94]

I am in Vancouver, Canada and my home server is located in Germany. The restore on a successful autosave in version 3.0.3 makes the app’s input fields unusable for me.
The effect is strongest when typing in bursts, interrupted by a brief pause for autosave to start.

[JavierRSobrino]

I dont know it this is related, but now everytime I try to edit a contact, it is never saved. The circle is constantly running indicating that it is saving, but it never gets saved.

[skjnldsv]

@JavierRSobrino anything in your browser's console?

How to access your browser console (Click to expand)

Chrome

• Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
• Alternative method:
  
  
  
  1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
  
  
  2. Click the “console” tab.
  
  

Safari

• Press CMD + ALT + I to open the Web Inspector.
• See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

IE9

1. Press F12 to open the developer tools.
2. Click the “console” tab.

Firefox

• Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
• or, if Firebug is installed (recommended):
  
  
  
  1. Press F12 to open Firebug.
  
  
  2. Click on the “console” tab.
  
  

Opera

1. Press CTRL + SHIFT + I to open Dragonfly.
2. Click on the “console” tab.