Contacts: [Vue] Cleanup css file names

Created on 2 Oct 2018  路  5Comments  路  Source: nextcloud/contacts
  • [ ] use vue filenames
1. to develop enhancement good first issue help wanted papercut
Source
picture skjnldsv

All 5 comments

What do you mean by "vue filenames". Components, index... ?

SerekKiri picture SerekKiri on 2 Oct 2018

@SerekKiri Hey!
I mean we use two different type of syntax here for our css files, the PascaleCase and kebab case.
But our vue components only use PascaleCase. We should unify this.

e.g. settings-section.scss -> SettingsSection.scss

skjnldsv picture skjnldsv on 2 Oct 2018

Ok, i will work on this 馃憤

SerekKiri picture SerekKiri on 2 Oct 2018
🎉1

@SerekKiri Awesome! Feel free to ask if you have any questions :)

skjnldsv picture skjnldsv on 2 Oct 2018
👍1

I made an PR, I hope this will help 馃槃

SerekKiri picture SerekKiri on 2 Oct 2018
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

despens picture despens  路  3Comments
spoorun picture spoorun  路  5Comments
brantje picture brantje  路  5Comments
juzim picture juzim  路  3Comments
keunes picture keunes  路  4Comments