Contacts: "groupname (new group)" stored

Created on 24 Nov 2017  ·  27Comments  ·  Source: nextcloud/contacts

Steps to reproduce

  1. Open any of your contacts
  2. Click in the Groups Textbox and Type a new Group Name. E.g. "mygroup"
  3. A suggestion will appear "mygroup (new group)"
  4. If you just hit Enter - everything is as expected, but if you select the suggestion "mygroup (new group)" is stored.

Expected behaviour

"mygroup" should be saved.

Actual behaviour

"mygroup (new group)" was saved.

Server configuration

PHP version:
7.0.19

Nextcloud version: (see Nextcloud admin page)
12.0.3

Contacts version: (see Nextcloud apps page)
2.0.1

Client configuration

Browser:
FF 57.0
Operating system:
linux

1. to develop bug help wanted medium

Most helpful comment

I can confirm this issue too.
But I found a possible workaround: After typing the group-name you can press "TAB" and the group is created without the string " (new group)".

All 27 comments

Same on NC 12.0.4, contacts 2.0.1

FF 52.5 ESR,
OpenSuse Leap 42.3

I can confirm the issue.

I can confirm this issue too.
But I found a possible workaround: After typing the group-name you can press "TAB" and the group is created without the string " (new group)".

thanks for the cool workaround, fapsi!

This is actually a bug in angular-ui. https://github.com/angular-ui/ui-select/issues/1806

Apparently there is already a fix for this which is awaiting review since 9 months... https://github.com/angular-ui/ui-select/pull/1943

The quick 'n dirty fix would be to add something like .replace(' (new group)', '') in the right place.

It seems there is some effort to change it on the way https://github.com/angular-ui/ui-select/pull/1943

@Benestar .replace(' (new group)', '') might be an option, even though we have to respect translations here.

I doubt ui-select will fix this. It doesn't seem maintained anymore (old AngularJS slowly falling apart :frowning_face: )

@Henni the pr fix in the select repo has been updated all day. Maybe if we cross our fingers! 🙏

I see https://github.com/angular-ui/ui-select/pull/1943 quite active, so there is a hope.

I can confirm that issue on the nextcloud docker image: nextcloud:13.0.0

Upping this to medium and help wanted since it seems to occur quite often. @nextcloud/javascript any ideas how to fix this?

angular-ui/ui-select#1943 has been closed, time to pull it to nextcloud

@gorn pr is still opened?

It is closed, but maybe with a manual hotfix (did not checked). If so, it might be easier to accept the upstream solution.

I don’t see that angular-ui/ui-select#1943 was merged. It seems still open as of today.

My tips (for waiting) : under "Thunderbird", if you have distant address book (CalDav), you can rename the category field manualy.

@Cortek29: Sounded like a wonderful idea, at first, BUT:

Be careful, you in fact can rename entries in the "category" field of Thunderbird's addressbook, but this will create a NEW group!

E.g:

  • 15 contacts in "groupA".
  • select one of these in TB's addressbook
  • rename "category" to "groupA_1"

Result in Nextcloud: 1 contact in "groupA_1", 14 still in "groupA", unchanged.

Maybe, if "renamed" group existed already, reassign to to existing group, haven't tested.

BTW: Afaik we're talking about cardDAV here, not calDAV. But doesn't matter :-)

TB 52.9.1
SOGo Connector 31.0.5
NC 13.0.5
NC Contacts App 2.1.5
all on OpenSuse 15.0

P.S.: I'm still using SOGo connector 31.0.5, although this version has a small but ugly bug, contact deletions from NC are not propagated to TB (https://sogo.nu/bugs/view.php?id=4094). Fixed for 31.0.6, but Inverse changed their FOSS policy, no final packaged addons anymore, only for paying customers. You have to built/compile on your own, and I've been to lazy up to now to dig into why comile failed after downloading. But if later SOGo connector also changed the way how category renamings are handled, from my experiences to what Cortek29 said, this would be another very good reason to overcome my lazyness :-)

@michaelof :+1:
Yes, cardDav, sorry :)

I try it successfully on my system. No problems. No duplicate, no new group.

But, the NextCloud is not mine, it's at my office, i don't have version or admin access...

@Cortek29: I've extended my last post during you've added you latest comment, not sure if you'll get a github notification about that. Which version of SOGo Connector are you using?

@Cortek29: P.S.: More ugly on my side: I can switch the group back to the original one, NC is updated at once by SOGo. And, as usual, NC drops "new" group, as not used anymore, in my example.
But SOGo conenctor will NOT delete these once used group, TB setting tab for SOGo lists all "categories" used, and offers a "delete" button. But nothing happens when clicked :-(
Again: Maybe fixed with 31.0.6 or later.

And we should not get to off-topic for a NC issue, probably, I'll stop now.

Sorry, but on my side, I use only. "Lightning" as manager of diaries and "CardBook" for contacts with Thunderbird, my OS is Debian fork (Mint).
It was after a problem of category renaming that I came across this discussion. I just explained my temporary solution. I do not use SOGo
I wish you good luck...

that is a bug at the moment (08/2018) the only way I know is :
import a .vcf file which leads the desired category name.

writhe a file with the content:

BEGIN:VCARD
VERSION:3.0
FN:AAA-test
NOTE:1
NOTE:1
TEL;TYPE=WORK,VOICE:2
TEL;TYPE=HOME,VOICE:3
TEL;TYPE=FAX:4
UID:
CATEGORIES:new-group
REV:
EMAIL;TYPE=HOME:[email protected]
END:VCARD

Save as a.vcf and import to the contacts
This creates a new group "new-group" without the stupid brackets. So you can also create empty contacts so you have not always have to click the necessary fields - which I find very annoying.
Also you can have 2 notes Create fields. ;)

I can still create groups without "(new group)" by pressing Enter instead
of clicking the label.

On Tue, Jul 31, 2018, 15:00 joe-pirat, notifications@github.com wrote:

the only way I know is :
that is a bug at the moment (08/2018) it only helps to import a .vcf file
which leads the desired category name.
writhe a file with the content:

BEGIN: VCARD
VERSION 3.0
FN: AAA 1
NOTE 1
NOTE 1
2: TYPE = WORK, VOICE; TEL
3: TYPE = HOME, VOICE; TEL
TEL; TYPE = FAX: 0351 808
UID:
CATEGORIES: new-group
REV:
[email protected]: TYPE = HOME; EMAIL
END: VCARD

Save as a.vcf and import to the contacts
This creates a new group "new-group" without the stupid brackets. So you
can also create empty contacts so you have not always have to click the
necessary fields - which I find very annoying.
Also you can have 2 notes Create fields. ;)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/contacts/issues/444#issuecomment-409381939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKXlSOBHQNL4lx0Rh11FpwgaUghqB9LRks5uMNN5gaJpZM4QpQlA
.

@skjnldsv I assume that since you added this to the 3.0.0 milestone and then closed it, users should be able to rename groups from Nextcloud's UI once 3.0 is released? Just want to be clear when talking to everyone using my server.

@evaryont Hey!
Nope, renaming groups are a completely different feature :(

is it fixed in nextcloud 14? because 13 is stil doing it.

@walley This is fixed in the 3.0.0 version of contacts

Was this page helpful?
0 / 5 - 0 ratings

Related issues

juzim picture juzim  ·  3Comments

RobertZenz picture RobertZenz  ·  4Comments

jtrees picture jtrees  ·  3Comments

spoorun picture spoorun  ·  3Comments

michaelletzgus picture michaelletzgus  ·  5Comments