Contacts: if 'last name' sorting has been set the comma between the last and first name should be suppressed when no first name has been entered

[j-ed]

Expected behavior

If the sorting order last name has been set, the comma which usually separates the last and first name, should be suppressed when no first name has been entered.

Current behavior

A comma behind the last name is always shown independently if a first name has been entered or not.

Steps to reproduce

1. Open the contacts app
2. Set the sorting order to 'last name'
3. check-out a contact for which no first name has been entered.

Environment

Server Configuration

OS: Linux 3.16.47
Web server: Apache2 2.4.26
Database: MariaDB 10.0.32
PHP version: 5.6.30
Nextcloud version: 12.03
Contacts app version: 2.0.0

Client Configuration

Browser: Mozilla Firefox 56.0
Operating system: Windows 7

[irgendwie]

Thanks for taking the time and reporting these issues! :+1:

[Nitiquita]

I'm going to try working on this! Is there a way I can build locally? Where can I find the last name sort? Thanks!

[Henni]

@Nitiquita take a look at this section: https://github.com/nextcloud/contacts#building-the-app

To get going with this issue, you might want to start over here: https://github.com/nextcloud/contacts/blob/master/js/components/contact/contact_controller.js#L15

[j-ed]

@Nitiquita It seems that a pull request already exists for this issue: https://github.com/nextcloud/contacts/pull/377

[suntala]

I am interested in working on this issue, but I am having trouble recreating it as you can see in this picture: https://screenshot.net/ognzyiz (please ignore the red boxes). Any ideas why?

[skjnldsv]

@suntala you need to use the full name detailed field to reproduce this issue! :)

[suntala]

@skjnldsv thanks for the info! That made all the difference.

[suntala]

Could I please be assigned this ticket?

[skjnldsv]

@suntala, don't ask, assign yourself and push a pr! :)