Contacts: Phonetic name support

[nickvergessen]

Should we downstream https://github.com/owncloud/contacts/pull/595/files ?

Add new props (see https://github.com/nextcloud/contacts/issues/251#issuecomment-412543730) into the rfcProps model!

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[MariusBluem]

I see no reason why not 😅

[jancborchardt]

Yes, everything should be downstreamed. Also cc @nextcloud/contacts and the original patch submitter @t-bucchi :)

[norbusan]

Yes yes yes!!! Please. Living in Japan I am in dire need of phonetic name support. Thanks!

[t-bucchi]

Hi, I'm a original patch submitter.
I want to merge this patch to nextcloud also.
Is there anything I can do for you?
Thanks.

[jancborchardt]

@t-bucchi cool, welcome! :) You could either cherry-pick the commits with gits functionality, or manually apply the changes since maybe the code underneath changed meanwhile.

If you have any questions, @nextcloud/contacts can help you. :) You are also welcome in our chat channel at #nextcloud-contacts! :tada:

[skjnldsv]

@jancborchardt it could be great to add it into the 3.0 update, but the code is completely different.

I'd like to know a few informations @t-bucchi
X-PHONETIC-FIRST-NAME is not an official prop, so before we go for it, I'd like to ve sure this is supported on other systems. Google is ok with this? What does it do on Android? iOS?

Davdroid seems to use this: https://www.davdroid.com/manual/supported-contact-fields/
Which I'm ok with. But creating invalid vcards by extending the N field to more props, I'm not really ok with that
https://developer.android.com/reference/android/provider/ContactsContract.CommonDataKinds.StructuredName

[t-bucchi]

@jancborchardt Thanks for your reply. I will merge my patch to current master.

@skjnldsv Google Contacts on web, Android and iOS support X-PHONEIC-FIRST-NAME. I attached vCards are exported from iOS and Google Contacts. Could you confirm its?
google.vcf.txt
ios.vcf.txt

And, my patch doesn't extend N field. It changes name order when generates full name from N field to display. Because, in Japan, we use "LAST-NAME FIRST-NAME" order generally.

[skjnldsv]

@t-bucchi thanks for the feedback!
Android extend the n property, that's why I mentioned it :)

I'm ok with using the X-PHONETIC props. It looks like the proper way to do since the rfc allow us to do so. Let's try to add this in 3.0.0

[t-bucchi]

@skjnldsv Thanks! I'm going to merge.

[skjnldsv]

@t-bucchi to merge?

[t-bucchi]

@skjnldsv Ah, I mean rebase or adjust my patch to head of master branch. I don't need to do it?
I'm creating the environment to develop. Current nextcloud/contacts looks working on Nextcloud 14 beta only.
What the revision of nextcloud/server should I use? Is head OK?

[skjnldsv]

We'll implement it in the 3.0 update. Your patch is not compatible. Don't worry we'll take care of it! 🤗

[t-bucchi]

@skjnldsv Oh! Thanks! I'm looking forward to 3.0 update!

[norbusan]

Is there any progress wrt to phonetic name support? There has been a patch, lots of updates, and at the end we are at NC16 and still without phonetic name support.

Could one of the devs please explain what the problem is? Thanks

[skjnldsv]

@norbusan time is the problem.
Maybe you can do it? We'd be really happy to receive some help from motivated contributors like you! :)

[norbusan]

@skjnldsv thanks, that is not very helpful. I am contributing to lots of projects (see my github), but these kind of remarks don't really invite contributors.

I checked the source now, it all seems to rely on ical.js, if I am not wrong. But some pointers could help people instead of pissing them off with these kind of remarks.

Thanks

[skjnldsv]

@skjnldsv thanks, that is not very helpful. I am contributing to lots of projects (see my github), but these kind of remarks don't really invite contributors.

How so? You seemed motivated on your message and willing to have this feature, so I assumed you could have helped us here?

Though now I'm really not fan of the tone of your last message.
You do realise we're all contributors and this is an open source project, right?
Anyone can work on an issue. And suddenly stating without a greeting "Hey lots of release later, you still did not do this, how so? Please explain the problem" will aaaabsolutely not motivate me to work on this.

I would have preferred something like
"Hello! Thanks for the latest releases. I see that this is still not part of the project. Could I do anything to help ? Thanks!"

There I would have even given you pointers! :wink:
https://nextcloud.com/code-of-conduct/

[skjnldsv]

I may be overreacting.
Sorry, I think I was hoping for a more encouraging message and yours depressed me a bit seeing that there was indeed a lot of time passed and still some nice pending features. :confounded:

So please accept my apologies. Let's be productive here! 🤗

---

This requires a bit of work as you could simply add two independent input in the rfcprops.js file, but this is quite not the best ux/ui. Ideally we should add two more inputs into the N field, but the way our data structure is designed does not really allow a split between a single property (vue) and multiple properties (vcard).

[norbusan]

Hi @skjnldsv
thanks for your remarks about how to tackle the problem. I will take a look. I know my way around in angular, but you have switched to vue, which I don't know at all.

Is there at least a general agreement on the vcard field naming? Reading the thread here I don't get the impression that going with X-PHONETIC-FIRST-NAME etc is accepted.

Thanks

Norbert

PS: nothing to worry about your comment, and I agree I could have been less pushy, sorry for that.

[skjnldsv]

Is there at least a general agreement on the vcard field naming? Reading the thread here I don't get the impression that going with X-PHONETIC-FIRST-NAME etc is accepted.

Any X- property is valid according to the rfc :)
It is not officially supported, but other big orgs like to create vcards standards (a bit like css webkit/moz prefixes before the official css releases)
So Google is using a a dedicated property, but Davdroid created a consensus and matches the two automatically https://www.davx5.com/manual/technical_information.html#name

Thanks!! :hugs:

[t-bucchi]

Hi. I wrote the new patch for this issue based on v3.3.0 .
I want to send pull request.
But, the master looks changing rapidly (many marge).
So, it's difficult to test my patch based on master.
Should I wait until the merge is complete?

[skjnldsv]

@t-bucchi open a pr, I'll help you get it merged even with master changes, don't worry :)
The two other big prs are #1687 and #1688, and it's still in need for some work, so we can try to merge yours before the two others ;)

[t-bucchi]

@skjnldsv Thank you for your help!
I'll send pull request soon.
Thanks!!