Consul: Bug on budget investments pagination

[decabeza]

Description

Type: Bug

Current Behavior

When use pagination on admin/budgets/N/budget_investments after "Select/unselect" a budget investment appear the following error:

Expected Behavior

Use pagination on admin/budgets/N/budget_investments after "Select/unselect" a budget investment without generate an error. 🤓

Steps to reproduce

1. Visit admin/budgets/N/budget_investments
2. Select or unselect a budget investment.
3. Use pagination.

Screenshot

Notes

A possible fix would be to change the line in app/views/admin/budget_investments/toggle_selection.js.erb so it doesn't re-render all investments but only the one which has just been selected (a similar implementation can be found in app/views/admin/legislation/proposals/toggle_selection.js.erb). The line currently reads $("#investments").html('<%= j render("admin/budget_investments/investments") %>');.

[behraaang]

Hello dear @decabeza
I am working to solve this issue, will make a pull request in a short time.
thank you.

[behraaang]

I have made a pull request to this problem, my fork had 3 failing tests which are not related to this issue and are not passing the test suite as result, is that okay?

[Moisi]

This issue considered closed?

[decabeza]

Closed by https://github.com/consul/consul/pull/3034/