Consul: "Remove external_link from debates" is beaking migrations

[andion]

The app's migrations try to remove external_link from debates table twice

• The first app migration creates an external_link column on debates.
• This column gets removed right after that, on the next migration.
• The column is not being added again, but this migration tries to remove the column again so it breaks any migration from previous versions.

The cause is this migration being deleted on this commit while adding the one mentioned.

It can be solved by re-adding the deleted migration or removing the new one. But either way it will break apps that executed migrations after that commit and will require interaction from the user migrating the database (i.e. remove the migration timestamp from schema_migrations).

[ferblape]

Good! I was just going to send the same issue and the same PR

:+1:

[ferblape]

@andion you didn´t create a PR, but that's the best way for consul to accept your change. Do you want help to create one?

[andion]

@ferblape I only pointed it out and proposed two solutions because I think it's better the team decides about how to solve this one. What do you think?

[ferblape]

I'd create a PR as desribed here: https://github.com/consul/consul/blob/master/CONTRIBUTING_EN.md#resolve-an-issue

That way, the team will know that there's a possible solution for an issue.

[andion]

@ferblape I'll do that then 😄