Confluent-kafka-dotnet: Producer best practice

Created on 8 Apr 2019 · 9Comments · Source: confluentinc/confluent-kafka-dotnet

What's the best practice for producer creation in things like web requests?
I believe we should be using one producer for multiple requests, i.e. create a singleton that always provides the same object and going by this question that seems correct?

So say if we have a singleton class that creates a producer with new ProducerBuilder<string, string>(config).Build()
Will the GC be able to handle this or do we need to dispose when app is ending? So if we kill/restart the app, would it leak?
Possibly prematurely worrying here but thought it would be worth asking.

Cheers

question

Source

robertocpsilva1

All 9 comments

suggest creating a lightweight wrapper class around the producer that takes IConfiguration as a constructor argument and sets everything up + is IDisposable. Then add this as a singleton in ConfigureServices and use dependency injection to access the instance in your web request handlers.

i'm about to start writing a blog post on exactly this - look out for that (though there is some chance I'll change my mind on the topic, no guarantees until it's out!).

mhowlett on 8 Apr 2019

Thanks, sounds good. Looking forward to the blog, where would it be posted?

robertocpsilva1 on 8 Apr 2019

the confluent website

mhowlett on 8 Apr 2019

👍1

the confluent website

Is there a url now ?

Rwing on 3 Jun 2019

sorry, haven't done it yet.

mhowlett on 3 Jun 2019

👀1 😄1

hi there. I am wondering if the Producer implementation is thread safe and the intention is to keep it thread safe. Also I haven't looked at the code, is it using HttpClient underneath because it may cause issue if we have a singleton HttpClient?