Configuration-as-code-plugin: Mapping#putIfNotEmpry

Created on 14 Oct 2019  路  3Comments  路  Source: jenkinsci/configuration-as-code-plugin

Description

  • [ ] Please mark the incorrectly spelled method putIfNotEmpry deprecated
  • [ ] add new method called putIfNotEmpty
  • [ ] old method should call new method (to avoid duplication)
  • [ ] add a javadoc for old method to suggest use new method instead. (See howto)

The problem with IDEs is that everyone is using the autocompletion and doesn't see such misprint.

https://github.com/jenkinsci/configuration-as-code-plugin/blob/045631a8bf8b2fb0ac219128a82dca5b34716869/plugin/src/main/java/io/jenkins/plugins/casc/model/Mapping.java#L50

@ndeloof one more 馃嵑 for me :-)

bug good first issue hacktoberfest

All 3 comments

Good candidate for hacktoberfest to fix the spelling.

Hi! Can I pick this up as part of the hacktoberfest?

@bojanfilipovic Please go ahead, please check the CONTRIBUTING

Was this page helpful?
0 / 5 - 0 ratings