Conference-app-2020: Suppress warning "Use FragmentContainerView instead of fragment tag"

Created on 18 Jan 2020  路  8Comments  路  Source: DroidKaigi/conference-app-2020

Kind (Required)

  • Improvement

    Overview (Required)

  • Use FragmentContainerView instead of fragment tag in activity_main.xml

Screen Shot 2020-01-18 at 14 37 37

## Links

easy welcome contribute

All 8 comments

I tried it, but it was a little difficult. We want to do it if we can. 馃槶

replaced and then getting error.

2020-01-18 14:47:47.682 8484-8484/io.github.droidkaigi.confsched2020.debug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: io.github.droidkaigi.confsched2020.debug, PID: 8484
    java.lang.RuntimeException: Unable to start activity ComponentInfo{io.github.droidkaigi.confsched2020.debug/io.github.droidkaigi.confsched2020.MainActivity}: java.lang.IllegalStateException: Activity io.github.droidkaigi.confsched2020.MainActivity@1a5433f does not have a NavController set on 2131362199
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2913)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
     Caused by: java.lang.IllegalStateException: Activity io.github.droidkaigi.confsched2020.MainActivity@1a5433f does not have a NavController set on 2131362199
        at androidx.navigation.Navigation.findNavController(Navigation.java:61)
        at io.github.droidkaigi.confsched2020.MainActivity$navController$2.invoke(MainActivity.kt:83)
        at io.github.droidkaigi.confsched2020.MainActivity$navController$2.invoke(MainActivity.kt:68)
        at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
        at io.github.droidkaigi.confsched2020.MainActivity.getNavController(Unknown Source:7)
        at io.github.droidkaigi.confsched2020.MainActivity.setupNavigation(MainActivity.kt:153)
        at io.github.droidkaigi.confsched2020.MainActivity.onCreate(MainActivity.kt:93)
        at android.app.Activity.performCreate(Activity.java:7136)
        at android.app.Activity.performCreate(Activity.java:7127)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2893)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)聽
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)聽
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)聽
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)聽
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)聽
        at android.os.Handler.dispatchMessage(Handler.java:106)聽
        at android.os.Looper.loop(Looper.java:193)聽
        at android.app.ActivityThread.main(ActivityThread.java:6669)聽
        at java.lang.reflect.Method.invoke(Native Method)聽
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)聽
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)聽

FragmentContainerView bug.
https://issuetracker.google.com/issues/143145612

I think it's ok to add tools:ignore="FragmentTagUsage" to ignore this lint.

Sounds good! It looks better if comments are written with the ignoring attribute.

Is there anyone who wants to do it? It's easy to contribute.

Can I do this?

Thanks! Assigned 馃憤

@STAR-ZERO I will change the title of this issue. 馃檹

Was this page helpful?
0 / 5 - 0 ratings

Related issues

KeithYokoma picture KeithYokoma  路  6Comments

takahirom picture takahirom  路  5Comments

takahirom picture takahirom  路  5Comments

takahirom picture takahirom  路  4Comments

FujiKinaga picture FujiKinaga  路  4Comments