Conductor: Add getString() method to Controller

[jpetitto]

Thoughts on adding a getString method to the Controller class? This convenience is offered by both Activity and Fragment in the Android framework and prevents having to reference Resources first.

I'd be happy to make this contribution if it gets the go ahead.

Note: there is also a second, overloaded method for handling string formatting as well.

[JakeWharton]

This doesn't seem like a good idea.

On Sat, Jun 11, 2016, 8:13 PM John Petitto [email protected] wrote:

Thoughts on adding a getString method to the Controller class? This
convenience is offered by both Activity and Fragment in the Android
framework and prevents having to reference Resources first.

I'd be happy to make this contribution if it gets the go ahead.

Note: there is also a second, overloaded method for handling string
formatting as well.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bluelinelabs/Conductor/issues/66, or mute the thread
https://github.com/notifications/unsubscribe/AAEEETOD3U_VmDd5suKwyYboaOr9WaJbks5qK08agaJpZM4Izq2T
.

[jpetitto]

Can you elaborate?

[JakeWharton]

Resources have nothing to do with view composition and backstacks.

On Sat, Jun 11, 2016, 10:52 PM John Petitto [email protected]
wrote:

Can you elaborate?

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/bluelinelabs/Conductor/issues/66#issuecomment-225406690,
or mute the thread
https://github.com/notifications/unsubscribe/AAEEEcH05L6xU5Jh-i9i-t7GV5aMX57hks5qK3RqgaJpZM4Izq2T
.

[EricKuck]

This should be easy enough to add to the application layer to not be required at the library layer.