Conda-build: Build failure on appveyor that is new in 1.21.6

[mwcraig]

I tried out 1.21.6 tonight and got a build fail that I do not get with 1.21.5 (though the version of 1.21.5 I'm using is patched to take pin-numpy and setup-options).

A build that fails is at: https://ci.appveyor.com/project/Astropy/conda-channel-astropy/build/1.0.172#L1183

If you look at the history of the builds for that project, the one immediately before it, which uses 1.21.5, passes (I tried switching back and forth a couple times in case it was a fluke).

[msarahan]

Yikes, something is trashing os.environ. Looks like something that is fine for a single build, but bad for conda-build-all. I have encountered things like this while playing with #1119, but had not seen it with 1.21.6. I'll look into it.

[ocefpaf]

I believe https://github.com/conda-forge/staged-recipes/pull/1111#issuecomment-234246070 is probably related to this, right?

[msarahan]

Yeah, looks related. Could be an issue in either conda-build or conda-build-all - but given that conda-build 1.21.5 works, perhaps more the former.

[ocefpaf]

If you need a test case let me know and I can try it on https://github.com/conda-forge/humanfriendly-feedstock/pull/1

[patricksnape]

Must be something to do with these changes since they are the only thing that messes with the environ?

[msarahan]

yes, @patricksnape that seems likely. At the least, I should limit my env modifications to PATH.

[jakirkham]

Yep, also seeing this.

[jakirkham]

Should add I see this even with builds that don't use numpy or python. For instance, this one just doesn't have dependencies. Same error message though.

source tree in: C:\Miniconda\conda-bld\work\nsis-2.46
Traceback (most recent call last):
  File "C:\Miniconda\Scripts\conda-build-all-script.py", line 9, in <module>
    load_entry_point('conda-build-all==0.13.0', 'console_scripts', 'conda-build-all')()
  File "C:\Miniconda\lib\site-packages\conda_build_all\cli.py", line 85, in main
    b.main()
  File "C:\Miniconda\lib\site-packages\conda_build_all\builder.py", line 224, in main
    built_dist_location = self.build(meta)
  File "C:\Miniconda\lib\site-packages\conda_build_all\builder.py", line 181, in build
    return bldpkg_path(build.build(meta.meta))
  File "C:\Miniconda\lib\site-packages\conda_build_all\build.py", line 32, in build
    build_module.build(meta, post=None, need_source_download=True, **kwd)
  File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 573, in build
    windows.build(m, build_file, dirty=dirty, activate=activate)
  File "C:\Miniconda\lib\site-packages\conda_build\windows.py", line 207, in build
    fo.write(msvc_env_cmd(bits=cc.bits, override=m.get_value('build/msvc_compiler', None)))
  File "C:\Miniconda\lib\site-packages\conda_build\windows.py", line 114, in msvc_env_cmd
    vcvarsall_vs_path = build_vcvarsall_vs_path(version)
  File "C:\Miniconda\lib\site-packages\conda_build\windows.py", line 75, in build_vcvarsall_vs_path
    PROGRAM_FILES_PATH = os.environ['ProgramFiles']
KeyError: 'ProgramFiles'
Command exited with code 1

[msarahan]

Fixed in #1135 - closing for now.