Conan: Improve '.editorconfig' file

Created on 16 Jul 2020  路  7Comments  路  Source: conan-io/conan

image

low good first issue low queue engineering

All 7 comments

Hey! could you give some more insight into this? I'd like to make my first contribution. Can I work on this?

Sure, more than welcome. Thanks!

Consider modifying first the .editorconfig file in a PR and then we will eventually modify (step by step) all the files using it, do not make a PR modifying 2000 files 馃槃

Thanks!

Yeah got it, thanks a lot!

Okay, so I need to put the line(s?)mentioned by @memsharded into the .editorconfig file and the make a pull request?

Yes @artorias111

The key here is to know what lines is necessary to put in .editorconfig that defines what to do with the multiple line indentation, I don't know if it is even possible.

I don't love the output of "black" formatter, but I am starting to consider it a possibility for Conan 2.0 codebase.

Hey!
I found this:
https://github.com/editorconfig/editorconfig/issues/412
This seems to be a _continuation_indent_size_ related issue.
it appears the _continuation_indent_size_ property is "domain-specific"(i.e. specific only to some languages, hence not implemented by the .editorconfig file), as stated here in the EditorConfig wiki: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties

Hi @artorias111

I have been playing with Pycharm, and it doesn't seem to support that editorconfig configuration.
Then, I think we should just define some convention and try to attach to it.

I vote for using the default Pycharm one, which is extra indent the code, like:

if (something and 
        otherthing):
    do_something()

But lets use what the majority of maintainers want.

Was this page helpful?
0 / 5 - 0 ratings