conan-center-index official community reviewers

[memsharded]

Pull requests opened to this repository, conan-center-index are reviewed by the maintainers and the community. To be merged, every pull request should have at least 3 positive reviews, at least one of them from one of the maintainers, but the other can be from any of the approved contributors:

@madebr
@SpaceIm
@ericLemanissier
@prince-chrismc
@Croydon
@intelligide
@theirix
@gocarlos

Many users have been doing great contributions to ConanCenter, and we are really grateful for those amazing contributions, thanks very much to all of you! These users have been enabled due to their outstanding history of contributions, with pull requests or reviewing and helping other users. This list might evolve and new contributors might be enabled in the future as well. Please read conan-io/conan-io.github.io/pull/145 for more details.

Note: The feature is not enabled yet, we will update as soon as the system enables it.

If you have any questions, please do not hesitate to contact us.

[ericLemanissier]

Thanks! In order to help us (actually me) be up to the task (as the quote says: 🕷️"With great power comes great responsibility" 🕷️), is there already a set of guidelines for code review on CCI ?

[memsharded]

Thanks! In order to help us (actually me) be up to the task (as the quote says: 🕷️"With great power comes great responsibility" 🕷️), is there already a set of guidelines for code review on CCI ?

Good quote :)

We don't have any explicit review guidelines yet, in general we try to convert those guidelines to hooks whenever possible, but this is a good suggestion. I would say to apply your knowledge and common sense, raise any possible question you might have here, as an issue (maybe create a new tag or [reviewers] in the title), and we can start adding those answers in a dedicated section in the docs?

[uilianries]

A new file in conan-center-index/docs would be nice I think. All centralized and corresponding to CCI.

[danimtb]

With the latest changes in the build service https://github.com/conan-io/conan-center-index/blob/master/docs/changelog.md#17-september-2020---1742-cest we are now able to merge PRs automatically.

Here is an update on the current state: https://github.com/conan-io/conan-center-index/pull/2899#issuecomment-694700233

And we will enable 2 community reviews starting next week! 😄

[prince-chrismc]

To help close some open PRs which are ready, I wanted to share my search filters.

• open PRs you have not approved that passed (reversed/oldest)

Currently uneventful.... but quick and easy

• versions bumps

For those pesky PRs we'd rather forget

• least recently updated

[danimtb]

Finally, we have enabled the announced configuration.

Staring today, PRs will be automatically merged requiring just one approval from the Conan team and 2 additional ones coming from the above-mentioned community reviewers. Only the Conan team members are allowed to "block" a PR by requesting changes for now, but this can be changed in the future as we test the new feature.

I would like to document this community reviewers list, with the details about how the automatic merge works as well as the useful links provided by @prince-chrismc, so I will keep the issue open until then.

Thanks a lot for all the effort on the PRs, the reviews and reports that keep improving ConanCenter!! 😄 🏆 🥇

[ericLemanissier]

Does the merging bot merge PRS based only on the number of reviews, or does it wait for successful CI?
eg. https://github.com/conan-io/conan-center-index/pull/2984 is it "risky" to approve a change before CI is finished ?

[danimtb]

@ericLemanissier don't worry, it also checks that the CI is green, so you can approve a PR before the CI ends and if all the reviews are done, the bot will merge it