Compromise: Incorrect TypeScript Definition for sentences()

[MarkHerhold]

I believe there is a TypeScript definition issue with sentences():

Error:

Property 'subjects' does not exist on type 'ExtendedDocument<{ sentences(n?: number | undefined): Sentences; }, World, Phrase>'.

TS Code:

import nlp from 'compromise';
import compromiseSentences from 'compromise-sentences';
const nlpEx = nlp.extend(compromiseSentences);

nlpEx('Hi bob').sentences().subjects();

Working on observablehq:

[spencermountain]

ah, thank you. good find.
will add to next release.

[spencermountain]

yeah, it looks like typescript doesn't see the new methods from the plugin, can reproduce.
@Drache93 any advice?
cheers

[Drache93]

Ah yeh. @spencermountain Odd one, for some reason sentence() shows an overload, so it returns an ExtendedDocument if no parameters, otherwise returns Sentence correctly...I'll poke around!

[Drache93]

Oh right :D sentences(): ExtendedDocument<Ext, W, Ph> is a built in function (looks like it should actually take a parameter also...).

/** overload original sentences() method and return Sentence class**/

[spencermountain]

you're right - i added the missing param and I think it's properly overloaded now.
Thanks!
fixed in 13.3.2