Compromise: plugin-sentences is missing toQuestion/isQuestion functionality

Created on 18 May 2020  路  7Comments  路  Source: spencermountain/compromise

I noticed a couple bugs in the sentences demo:

_input_:

nlp(`I can't believe it's a law firm.`).sentences().toExclamation().text()

_output_:

"I can't believe it's a law firm."

(i.e. no effect)


_input_:

nlp(`I can't believe it's a law firm.`).sentences().toQuestion().text()

_output_:

"I can't believe it's a law firm."

(i.e. no effect)

bug fixed-on-dev priority

All 7 comments

ah - thanks

@spencermountain in the meantime, could you please let me know if I'd be able to use an older version of compromise to get the .sentences() conversion functions working?

If so, which version? Thanks!

oh - whoa.
i guess this is why it isn't working....
image
馃槼
will release a fix in the next day or two.
sorry bout that. not sure how this slipped-through

Haha yes! I happened to notice that just today.

Awesome thank you 馃憤

sorry - long week. This got stuck behind some other fixes. Will try to release this today. Thanks for the patience

basic support for these methods has been added in 13.3.0
thanks for your patience

Ooh so useful for my current project. Thanks a million!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

josephrocca picture josephrocca  路  5Comments

elderbas picture elderbas  路  7Comments

nelson-liu picture nelson-liu  路  3Comments

DominoTree picture DominoTree  路  5Comments

douglance picture douglance  路  6Comments