Compose: Pass --detach-keys to docker-compose

[Gijsjan]

docker run has the option to pass an alternative sequence to detach. Currently it is mapped to ctrl-p ctrl-q, but I heavily use ctrl-p in the cli and Vim, so I would like to remap. Is that possible with Compose? If not, this is a feature request. :)

[crhan]

while docker cli supports detach-keys. I do want the same feature applied in docker-compose too.

[vladimir-mencl-eresearch]

+1 - this would be a very useful feature

[qinix]

+1

[110y]

+1

[ihucos]

+1

[schasse]

:+1:

[jaywhy13]

+1 Question though... it's possible to save detachKeys in ~/.docker/config.json. When Compose runs Docker, why doesn't it use these configs?

[chhabrakadabra]

+1

[110y]

My workaround

docker exec -it $(docker-compose ps -q mycontainer) bash

[scmx]

I'm experiencing the same issue. (using Docker for Mac)

I've remapped my ~/.docker/config.json like this:

{
  "detachKeys": "ctrl-q,ctrl-q"
}

and it's working fine for normal docker run but not for docker-compose.

Would be awesome if the config file was read when using docker-compose. 🎉 Keep up the good work with this tool.

[kelly-apollo]

+1

[amosbird]

Hi, is there a pr for this?

[coxjonc]

+1

[scrooloose]

+1

[ihucos]

+1 again

[0xBADDCAFE]

+1

[kdeloach]

+1

[Nondv]

Is there any movement?

+1

[summergirl21]

Is this something that would be useful? If so I would be interested in tackling it.

[jaywhy13]

Yes! Exceptionally so

On Nov 30, 2017 1:45 PM, "Madeline" [e-mail] wrote:

Is this something that would be useful? If so I would be interested in
tackling it.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/docker/compose/issues/3311#issuecomment-348282236,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvmBkikxNG_RbaBSrbHsuECRvqDSHdkks5s7ve9gaJpZM4IFTF6
.

[Nondv]

@summergirl21 for example, it's not really comfy to use bash history via C-p because docker treats it as prefix and waits for next key. This is kinda frustrating:)
And think about vim/nano/whatever users, who use editor inside container. I guess now they are forced to use docker exec instead of docker-compose exec

[mtsmfm]

I sent a PR to fix this problem.
https://github.com/docker/docker-py/pull/1826

I guess it takes a while to get merged and released so I built patched docker-compose:
https://bintray.com/mtsmfm/docker/compose#files

It respects our detachKeys setting as well as docker command does.

Please let me know if you find any bugs 🐛

[hongliang5316]

Nice Job 👍 .

[jaywhy13]

Awesome

On Dec 23, 2017 01:58, "hongliang" [e-mail] wrote:

Nice Job 👍 .

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/docker/compose/issues/3311#issuecomment-353711008,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvmBq6qMiQb7-bmSE36gH7LBPsQOjblks5tDKSHgaJpZM4IFTF6
.

[lusitania]

AFAICS docker/docker-py#1826 was merged 2018-01-31 for milestone 3.0.0. Can this issue be closed @Gijsjan, @mtsmfm? In which version of docker-compose will this feature become available?

[mtsmfm]

In which version of docker-compose will this feature become available?

It's available from docker-compose 1.20.0

https://github.com/docker/compose/commit/d8d484e0e19db5326afeb4cdf56864eceb81566c#diff-b4ef698db8ca845e5845c4618278f29a