Components: Provide update schematics for google-maps and youtube-player package

Created on 11 Jul 2020  路  5Comments  路  Source: angular/components

Reproduction

Steps to reproduce:

  1. Have an Angular 9 app
  2. Update to Angular 10

Expected Behavior

Either https://update.angular.io/#9.0:10.0l3 should inform that it needs to be updated manually too, or it should update with @angualr/material.

Actual Behavior

Did only update @angular/material and @angular/cdk.

Environment

  • Angular:
  • CDK/Material: 9 => 10
  • Browser(s): ---
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
P4 google-maps ng-update youtube-player feature

Most helpful comment

It wasn't really hard to upgrade it manually, but since there are breaking changes, I had to go through my code to fix them manually. Either an automatic update or a list of changes to look for after updating would be nice.

All 5 comments

I'd say that this works as expected since @anguar/google-maps isn't related to @angular/material and @angular/cdk, apart from being in the same repository. I suppose we could provide ng update support for the Google Maps package specifically.

It wasn't really hard to upgrade it manually, but since there are breaking changes, I had to go through my code to fix them manually. Either an automatic update or a list of changes to look for after updating would be nice.

Yeah, it works as expected that ng update @angular/material does not update the youtube-player or google-maps package as those are separate unrelated packages. I agree though that we should probably set up update schematics for those packages if there are breaking changes.

I can understand why ng update @angular/material does not update other, but the update.angular.io should have a note about updating these

@Akxe you can open an issue for update.angular.io here: https://github.com/StephenFluin/angular-update-guide/issues

Was this page helpful?
0 / 5 - 0 ratings