Components: feat(top-app-bar): migrate toolbar to top-app-bar

Created on 3 Nov 2018  路  4Comments  路  Source: angular/components

Bug, feature request, or proposal:

feature request

What is the expected behavior?

Toolbar should be migrated to top-bar, there should be no toolbar component

What is the current behavior?

Toolbar, but no top- or bottom-bar

What is the use-case or motivation for changing an existing behavior?

The spec has been updated to not include a toolbar, instead allowing for "App bars", both top- and bottom-.

Is there anything else we should know?

MDC is also doing this, and it is being tracked here

Tasks

  • [x] Scaffold empty classes, assets, demo, build config, etc.
  • [ ] Stub existing component API
  • [ ] Hook up MDC foundation and adapter
  • [ ] Add remaining features on top of MDC implementation
  • [x] Test dark theme
  • [ ] Test RTL
  • [ ] Test with screen-readers
  • [ ] Copy existing unit tests and ensure they all pass
  • [ ] Copy existing e2e tests and ensure they all pass (if any)
  • [ ] Verify SSR support in universal-app/
  • [ ] Verify no size regression
  • [ ] Create test harness
  • [ ] Create schematics for migration
  • [ ] Create user documentation

    Additional notes

Breaking changes

Known issues & visual differences

P4 materiatoolbar feature major

Most helpful comment

馃い馃い馃い馃い馃い

ezgif-1-b45d38fe5d3a

All 4 comments

馃い馃い馃い馃い馃い

ezgif-1-b45d38fe5d3a

Related: MDC's mdc-top-app-bar

For reference, here's the merged PR for MDC's mdc-top-app-bar.

@mhosman that's a bottom-app-bar rather than top-app-bar. I've opened https://github.com/angular/components/issues/16367 to track the creation of a mat-bottom-app-bar.

Docs and a demo for the MDC Top App Bar are now available.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jmcgoldrick picture jmcgoldrick  路  59Comments

Daugoh picture Daugoh  路  79Comments

julianobrasil picture julianobrasil  路  78Comments

abdulkareemnalband picture abdulkareemnalband  路  165Comments

jelbourn picture jelbourn  路  171Comments