Components: ng1 upgraded component on dialog not working

Created on 8 Jul 2018 · 2Comments · Source: angular/components

Bug, feature request, or proposal:

bug

What is the expected behavior?

ng1 upgraded component works on material dialog

What is the current behavior?

Error: StaticInjectorError(AppModule)[$scope]:
StaticInjectorError(Platform: core)[$scope]:
NullInjectorError: No provider for $scope!

What are the steps to reproduce?

https://stackblitz.com/github/AminRahimi/ngUpgrade

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?

:heart:

Source

AminRahimi

👍1

Most helpful comment

This is because you didn't provide a viewContainerRef and therefore an injector that includes the upgraded component isn't being used.

constructor(public dialog: MatDialog, private viewContainerRef: ViewContainerRef) { }

onOpenModalClick() {
  ....,
  viewContainerRef: this.viewContainerRef,
});

devversion on 9 Jul 2018

❤4 👍4 🎉1

All 2 comments

This is because you didn't provide a viewContainerRef and therefore an injector that includes the upgraded component isn't being used.

constructor(public dialog: MatDialog, private viewContainerRef: ViewContainerRef) { }

onOpenModalClick() {
  ....,
  viewContainerRef: this.viewContainerRef,
});

devversion on 9 Jul 2018

❤4 👍4 🎉1

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}