Components: [sidenav] container styles not updated after sidenav destroy or mode change

[willshowell]

Bug, feature request, or proposal:

Regression

Expected

• Destroying a open sidenav should update container styles
• Modifying an open sidenav's mode should update container styles

Reproduction

http://plnkr.co/edit/eKqzpiCPUXGVHjknmq6F?p=preview

cc @crisbeto

[crisbeto]

Probably best to wait with this until https://github.com/angular/material2/pull/6260 is merged.

[willshowell]

@crisbeto, @mmalerba no major refactors are underway right now are they? I feel like this is a very important regression, especially the mode changing aspect.

[rosslavery]

This one is a really painful regression, any chance of getting an expedited merge, even so we can start using it via material2-builds?

[mmalerba]

The fix for changing modes has been merged: #6260. The fix for drawer removal is ready but not merged yet: #7060

[rosslavery]

@mmalerba I don't the fix in #6260 is working then, because switching modes only takes effect if you toggle the sidenav.

For example, if it's open and set to side and then you set it to over while it is open, it doesn't update. You need to close and re-open the sidenav for the new mode to take effect.

See Plunkr (based on issue template plunkr): http://plnkr.co/edit/ODfeJBJEece2dvMJesNj?p=preview

Should I create a new issue?

[willshowell]

@rosslavery I _think_ @mmalerba meant https://github.com/angular/material2/pull/6712 for the mode changes.

[rosslavery]

Ah...well then that one doesn't seem to be working either? Or is #6712 not
in beta 11?

Now I'm just confused 😛

On Sep 27, 2017 7:28 PM, "Will Howell" [e-mail] wrote:

@rosslavery https://github.com/rosslavery I think @mmalerba
https://github.com/mmalerba meant #6712
https://github.com/angular/material2/pull/6712 for the mode changes.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/angular/material2/issues/6271#issuecomment-332683867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoF9AMG7syBlQOzMcX2PI3oqGOUzCQ_ks5smtocgaJpZM4Otvw9
.

[willshowell]

@rosslavery I think it just barely missed beta.11. It's also not yet available in the material2-builds yet due to some CI issue

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}