Components: Add option to disable ripples globally

Created on 8 Nov 2016  路  5Comments  路  Source: angular/components

Bug, feature request, or proposal:

An option to globally disable ripple animations would help to reduce flakiness in screendiff testing.

What is the expected behavior?

Globally diable ripple animations for screen diff testing.

What is the current behavior?

Ripple animations can only be disabled on an element by element basis.

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

Making screenshot diff tests more reliable.

Which versions of Angular, Material, OS, browsers are affected?

angular/material2

Is there anything else we should know?

feature help wanted

Most helpful comment

This should probably be similar to disabling animations globally.

All 5 comments

This should probably be similar to disabling animations globally.

It would be a nice option to have.

Especially on mobile devices, the ripples animations kill anything but the top dog phones.

@tinayuangao Seems to be

  • [x] Done

feat(ripple): support for global ripple options (#3463)

https://github.com/angular/material2/blob/fb75a136e72489d75c44ca8e68d99352dc71afef/src/lib/core/ripple/ripple.ts#L20

So it is.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_This action has been performed automatically by a bot._

Was this page helpful?
0 / 5 - 0 ratings

Related issues

RoxKilly picture RoxKilly  路  3Comments

julianobrasil picture julianobrasil  路  3Comments

michaelb-01 picture michaelb-01  路  3Comments

dzrust picture dzrust  路  3Comments

vanor89 picture vanor89  路  3Comments