Community: Add info about keywords in commit messages in contributor guide

Created on 24 Apr 2019 · 4Comments · Source: kubernetes/community

The invalidcommitmsg prow plugin will disallow at mentions (like @nikhita) and keywords which close issues (like fixes #xxxx) in commit messages.

We should add this info to the contributor guide so that contributors know not to add these keywords in the first place.

cc @guineveresaenger @mrbobbytables

/sig contributor-experience
/area contributor-guide
/kind documentation
/good-first-issue

arecontributor-guide good first issue help wanted kindocumentation sicontributor-experience

Source

nikhita

👍2

Most helpful comment

I can take care of this!

nzoueidi on 21 May 2019

❤3

All 4 comments

@nikhita:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

The invalidcommitmsg prow plugin will disallow at mentions (like @nikhita) and keywords which close issues (like fixes #xxxx) in commit messages.

We should add this info to the contributor guide so that contributors know not to add these keywords in the first place.

cc @guineveresaenger @mrbobbytables

/sig contributor-experience
/area contributor-guide
/kind documentation
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.