Community-patch-dll: Request -- EUI new version changes merged

[ryanmusante]

_1. Mod version (i.e Date - 4/23):_
4/30

_3. Feature description_
A new version of EUI has been released with performance improvements and bugfixes.
Request that those parts be added to the EUI version of VP in upcoming patch.

https://forums.civfanatics.com/threads/enhanced-user-interface.512263/page-143#post-15125129

Enhanced User Interface v1.29beta17

This beta version includes the following changes:
- performance improvements
- minor tooltip improvements
- minor bug fixes
- ActionInfoPanel: enter key goes to next end blocking task
- ActionInfoPanel: the icon of players who are not yet done with their turn
- flashes in the civilization ribbon
- InGame: shows predictive unit firing range from where the unit will end up
- (red highlight), when checking unit moves with the path indicator while
- right click is pressed or in move mode...

[LoneGazebo]

I have zero interest in doing this, if someone else (@Infixo et. al.) want to work on it, it'd be appreciated.

G

[Infixo]

I am only interested in specific feature requests based on current game experience or errors we identify and are able to replicate. This ticket contains none.

[ryanmusante]

I don't know what specific bug fixes are entailed with the update.

I had hoped since it involved the user interface and many people are users of the EUI that it might be a useful addition.

[TechpriestEnginseer]

Considering that I love EUI. I'll take a gander. What's the version that this VP currently use before it got made compatible? I'll do some comparison and look into it.

However I will wait until the VP release a version within this month just in case some UI got changed.

[ryanmusante]

EUI_context.lua.bak in /UI_bc1/Core is dated 2016-01-17. This is a date before v1.28g 21mar2016. I am not sure which base version VP uses.

[LoneGazebo]

1.28c IIRC

[LoneGazebo]

maybe it is g- either way it was near the tail-end of bc1's changes before his departure.

[TechpriestEnginseer]

Actually, before I start working on it, which EUI UI folders are not being used? I know the Diplomacy screen isn't used because it interferes with the Civ 4 Diplo Features, but any other that I don't know yet?

[LoneGazebo]

I don't recall 100% techpriest - easiest way to know would be to winmerge compare the LUA from 6a with EUI's LUA - if the file is very different, then it is not EUI.

[Iamblichos]

How's this coming along? You need some help? I hate EUI, I also hate not using it, so if it's improved...that's at least a net good.

[TechpriestEnginseer]

Well, I just got off my college semester. I'm gonna work on adding extra events before this two-year's anniversary of what I "promised" to do. Then, I'll work on this.

[LoneGazebo]

@TechpriestEnginseer coming out of temporary retirement eh? welcome back! _I knew you couldn't quit us._

[TechpriestEnginseer]

@LoneGazebo as I'm working on merging them. What's bc1's views on VP taking over EUI and modifying it again? I remembered a common knowledge in the community was that VP EUI was very different from the normal EUI(No Diplo lua and so on). I think incorporating @Infixo's City View UI would be useful as well into the VP EUI since it is much of a QOL UI compared to EUI's current version right now. However it would mean that for the installer we have to remind users to have SmallAsset set to 1 after they install VP. Any thoughts?

[LoneGazebo]

@TechpriestEnginseer bc1 requested we not ship a customized EUI - rather, we have to overwrite stuff (as I do in 6a/6c).

Re: SmallAsset, let's leave @Infixo's out unless there's a method to change that value through the installer - not sure if I can (or want) to mess with .ini files in the installer.

[TechpriestEnginseer]

Progress Bar

• [x] ActionInfoPanel [Tested and bug-free!]
• [X] Art Assets [No bugs in an art file... can they?]
• [x] CityBanners [No bugs so far still testing...]
• [x] CityStatePopup [No bugs so far still testing...]
• [x] CityView [No bugs so far still testing...]
• [x] Core [Well if this thing starts getting buggy, everything else does so...]
• [x] FrontEnd [No bugs so far still testing...]
• [x] GameSetup [No bugs so far still testing...]
• [x] Improvements [No bugs so far still testing...]
• [x] InGame [No bugs so far still testing...]
• [x] ~LeaderHead~
• [X] Options [No bugs so far still testing...]
• [x] PlotHelp [No bugs so far still testing...]
• [x] TechTree [No bugs so far still testing...]
• [x] ToolTips [No bugs so far still testing...]
• [ ] TopPanel (I will never touch this at all)
• [x] UnitFlagManager [No bugs so far still testing...]
• [ ] UnitPanel (Will never touch this)
• [x] YieldIconManager [No bugs so far still testing...]
• [X] General Text File [No bugs so far still testing...]
• [ ] Public Testing

[Iamblichos]

And that LeaderHead was completely rewritten. Gonna be a grind on some of it.

[LoneGazebo]

@Iamblichos I wouldn't touch leaderhead - VP doesn't use EUI's leaderhead stuff anyways.

[Iamblichos]

Well that’s great.

[Iamblichos]

Looks like some good progress by TechPriest.

[ryanmusante]

Very nice work!

[TechpriestEnginseer]

When I'm about to release a beta version to the public and then he updates his interface. >:(

[LoneGazebo]

If you do a merge compare between versions @techpriestenginseer you can see what he changed and see if it is worthwhile or not.

[TechpriestEnginseer]

It's too worthwhile cuz the "performance improvements" are basically a lot of variable changes. I think I'll wait a week before he re-updates again.

[ryanmusante]

Are there plans to incorporate CSL2 mod into VP or will it be excluded in lieu of the other changes/revisions?

[TechpriestEnginseer]

Maybe.*

[ryanmusante]

This menu navigation looks interesting, what does that entail?

bc1 updated Civ5 Enhanced User Interface v1.29beta20

Changes since v1.29beta19:
- easier main menu navigation (LOAD GAME reduced from 2 to 1 step, MOD launch reduced from 6 to 3 steps)
- city states leaders can be enabled or disabled for low end rigs
- fallback for missing city states leaders (e.g. when using 2014 mod)
- improved city banner flag display
- minor fixes

[TechpriestEnginseer]

Unfortunately, I cannot tell if bc1 is intentionally doing these "performance fixes" on purpose or not, but it means we'll have to rewrite the new ui addition made into the new version which will take longer than just winmerging it.

[LoneGazebo]

@TechpriestEnginseer I swear he intentionally designs his code to be difficult to tinker with. We had quite a few heated exchanges a few years back and he was adamant that I 'wasn't allowed' to mess with his code. K.

[ryanmusante]

For an explanation of the EUI core library and C4DF from a previous conversation, I don't know if this might help some. Although code obfuscation, I can't help at all because I'm just an amateur.

https://forums.civfanatics.com/threads/issue-with-cp-eui.561596/

[LoneGazebo]

Lord that brings back memories of slamming my head against my keyboard.

[ryanmusante]

2014, In the beginning the gods created the mods.

https://www.reddit.com/r/civ/comments/20c0p8/this_is_the_enhanced_user_interface_mod_this_will/

[LoneGazebo]

@ryanmusante haha, dug too deep.

[TechpriestEnginseer]

Since bc1 keeps at sudden intervals updating along with the VP UI additions as well, I will hold this project off until the VP UI is "solid" for at least 3 months.

[TechpriestEnginseer]

Progress Bar for EUI v1.29beta28 from v1.28c or v[1.28beta3]

• [ ] ActionInfoPanel
• [ ] Art Assets
• [ ] CityBanners
• [ ] CityStatePopup
• [ ] CityView
• [ ] Core
• [ ] FrontEnd
• [ ] GameSetup
• [ ] Improvements
• [ ] InGame
• [x] ~LeaderHead~
• [ ] Options
• [ ] PlotHelp
• [ ] TechTree
• [ ] ToolTips
• [ ] TopPanel
• [ ] UnitFlagManager
• [ ] UnitPanel
• [ ] YieldIconManager
• [x] General Text File Compatibility
• [ ] Public Testing as 6aa and people saying wow literally no ((bugs))

Ok there's actually a lot added compared to where I was just pulling and requesting. My #1 priority should be those in bold... hoping this be done within a month before Christmas...
https://github.com/LoneGazebo/Community-Patch-DLL/issues/5013

[ryanmusante]

[MRS-OBAMA]

where can i see the progress? i'd like to help although i doubt i can =)

[TechpriestEnginseer]

don't worry, the update to the new version aren't exactly news-worthy to be waiting for since they'll just contain performance improvements.

[MRS-OBAMA]

Oh, It's because i tried porting for myself the new yieldiconmanager (as the improvement icon were really cute and a nice addition, but there are way too many variables that get switched and moved around so even just winmerging it is hard lol, i'll keep waiting i guess