Community-edition: Keyboard shortcuts to cycle through service tabs doesn't work

[fanis]

Steps to reproduce

1. Update to 0.6.4
2. Have multiple service tabs running (I have Whatsapp, Skype, Mattermost, Messenger)
3. Focus in one of them while using it.
4. Hit CTRL+TAB or CTRL+PGUP/PGDN to cycle through them

Expected behavior

Tab switches to the next one on the right like it did in previous versions.

Actual behavior

Nothing happens.
If you mouse click on the Service tab header itself (eg the "Whatsapp" icon and text) and then hit CTRL+TAB or CTRL+PGUP it works just once. You then need to mouse click on the current Service tab header again before CRTL+TAB or CTRL+PGUP to switch to the next one.

Looks like this functionality was introduced in #75. I've been using it for many versions.

ENVIRONMENT

Rambox 0.6.4
Electron 3.1.4
win32 x64 10.0.17134

[welcome[bot]]

Thanks for opening your first issue here! Be sure to follow the issue template!

[sylvainar]

Same here !
Version: 0.6.4
Plateforme: win32 (x64)
Electron: 3.1.4
Chromium: 66.0.3359.181
Node: 10.2.0
Windows 10

[StormPooper]

I'm getting the same thing. I also notice that Ctrl+[num] shortcuts no longer work either.

Version: 0.6.4
Platform: win32 (x64)
Electron: 3.1.4
Chromium: 66.0.3359.181
Node: 10.2.0

[maxerbox]

Can confirm
Version: 0.6.4
Platform: linux
Electron: 3.1.4
Chromium: 66.0.3359.181
Node: 10.2.0

[rwkyyy]

Not working on macOS either.

[BalintFarkas]

Can confirm on Windows 10
Version: 0.6.4
Platform: win32 (x64)
Electron: 3.1.4
Chromium: 66.0.3359.181
Node: 10.2.0

[LionelBino]

Same here
ubuntu 18.04

[crimsonsunset]

might revert until this is fixed. i slam that shortcut all day =/

[joaopsys]

Same here:

Version: 0.6.4
Platform: linux (x64)
Electron: 3.1.4
Chromium: 66.0.3359.181
Node: 10.2.0

[maxerbox]

Since chromium's architecture has been reworked, events are not propaged globally anymore. Rambox was using this hack to handle CTRL+TAB, but with the new electron version, it's not working anymore.
A workaround is to handle the events fired by webview.
Fixed in #2138

[RicoLaaa]

+1 really a pain when you are using multiple services... which is the main purpose of Rambox.. :/

[SebastianMueller87]

+1 (macOS)

[maxerbox]

I neee some reviewers for the push request ^^, feel free to review it

[lasombra]

I tested the PR. Ctrl+number works fine. Ctrl+PgUp or Ctrl+PgDown doesn't work reliably; it seems it gets captured by the webview.

[BalintFarkas]

@maxerbox I tried to build Rambox from source to but failed with some cryptic Sencha error that I was unable to fix. If you can please provide a win64 build I'll test it gladly.

[crimsonsunset]

I tested the PR. Ctrl+number works fine. Ctrl+PgUp or Ctrl+PgDown doesn't work reliably; it seems it gets captured by the webview.

any idea if it fixes ctrl+tab / ctrl+shift+tab ?

[lasombra]

Ctrl+Tab / Ctrl+Shift+Tab works, but I just noticed that all working shortcuts only work after you click on a tab, any tab. Then the shortcuts work.

It looks like the keyboard focus is on the webview when you start Rambox. Only after clicking on a tab that the shortcuts start to work normally.

[metal3d]

@lasombra it doesn't work as expected, It only switch one tab, and then... nothing happens

[metal3d]

Note: If you're on the Rambox welcome tab, CTRL+PageDown works if you clicked on the tab title. Then, after the first switch, nothing happens on that shortcut. It seems that the webview is capturing the keyboard.

[maxerbox]

@metal3d @lasombra
Fixed pageup-pagedown-zoomin-zoomout issue

[lasombra]

@maxerbox Good stuff! To me, the remaining problem is the initial usage of the shortcut requiring a click on any tab to work.

[maxerbox]

Wdym ? You need to focus rambox window to make it working anyway.
It seems working even from the Rambox tab (where you add services)

[lasombra]

Ah, never mind @maxerbox, sorry for the confusion. The problem is that the dev tools, which open side by side to the webview, has the initial focus.

[metal3d]

@maxerbox I'm impatient to use the next release so :)

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.