Common-voice: [mobile] User menu is not entirely accesible

Created on 2 May 2019  路  12Comments  路  Source: mozilla/common-voice

Env:
iPhone 7, iOS 12.2, Firefox and Safari

STR:
Login to https://voice.allizom.org/en
Tap the avatar to see user menu options

Expected:
User can scroll down to see all user menu options available and can access any of them

Actual:
Settings and Logout options are not available, user cannot scroll down to see these options.

Note:
On devices with larger screen like iPhone X, only the Logout buttton is not accessible.
photo5931728274390626443

Bug good first issue

Most helpful comment

@phirework , Thanks for accepting my pull request, as it was my very first open source contribution :)

All 12 comments

@viorelaioia thanks for your feedback. Working on it already.

@viorelaioia, I fixed this problem.

Verified as fixed.

@viorelaioia has there been a regression on this? I'm noticing the same behaviour.

@rileyjshaw , I tried on a iPhone 7 device and I'm able to access all menu items. I don't have a device with a smaller screen. But I tried on an emulator and it seems the issue it's still happening.

@viorelaioia thanks for testing! I'm able to reproduce on a laptop by shrinking my browser to tablet width with reduced height.

@rileyjshaw , I confirm I can also reproduce it the way you mentioned.

The fix for mobile devices consisted of reducing the padding between menu items, so that they fitted in the small space.

This fix can be extended to bigger devices too, by changing the line of code shown in the image below to: @media (--md-up) {
It would apply the padding reduction to extra small and small devices, including small tablets.
The file is web/src/components/layout/nav.css

2019-11-02

@viorelaioia I have fixed it by adding overflow property. https://github.com/mozilla/voice-web/pull/2547

@phirework , Thanks for accepting my pull request, as it was my very first open source contribution :)

@manishkr1101 Woohoo! Welcome :)

Looks good, @manishkr1101 ! Thanks!
Closing the issue, as it's fixed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ivonnekn picture ivonnekn  路  5Comments

mikehenrty picture mikehenrty  路  3Comments

kenrick95 picture kenrick95  路  4Comments

connorshea picture connorshea  路  5Comments

LucSalommez picture LucSalommez  路  5Comments