Common-voice: Sign Up for Emails through the Footer

Created on 23 Aug 2018  Â·  11Comments  Â·  Source: mozilla/common-voice

footer_01
footer_03
nav_footer 2 hover
nav_footer 2 done
footer_02

help wanted

Most helpful comment

@Gregoor Would it be okay with you if I tried to implement this?

All 11 comments

@mbransn happy to put this in. Some unanswered questions, which I think we talked about before, but didn't answer yet:
1) Should this do the same thing as adding an email to the profile and checking the sendEmails flag? I.e. after filling it out and then navigating to profile, is that information filled in?
2) Would this be hidden after one subscriped (and the page was reloaded)?

Yep, great questions, good to work through and make live when we're fully aligned. cc @mikehenrty as I want to ensure my thoughts align with his :)

  1. Should this do the same thing as adding an email to the profile and checking the sendEmails flag? I.e. after filling it out and then navigating to profile, is that information filled in?
  • For logged out/non-signed up users: No
  • For logged in users: Yes. If logged in users already have this email subscription flagged, they will see this state >> will work with @georai to ensure there is a link to edit their preference from this state as well.
  1. Would this be hidden after one subscriped (and the page was reloaded)?
    See my answer for logged in users above :)

I just realized that what I alluded to in the user settings docs also applies here, namely:

The Email/Marketing team said it’d be painful to manage the “subscribed”-state on both our and their side and their recommendation was that we’d link to the Mozilla-wide email settings page

But that very much constrains what we can do here. It'd mean we'd have to always show the email subscription field, as we wouldn't know whether the user already signed up. We could still have our own flag in our DB but that would become invalid as soon as the user changes their setting through the Mozilla-wide email page.

Hmm, alright. I'm fine with always showing the field. :) No need to over engineer it! More importantly, we will provide an updated email subscription section for you that includes a CTA to link out to the Moz-wide settings page.

Backend endpoint is in place, only thing missing now is the frontend

@Gregoor Would it be okay with you if I tried to implement this?

@jkmdev more than okay! Let me know if you want to talk through it.

@jkmdev here are links to UI for desktop and mobile, thanks for jumping in to help! 👏

@mbransn Thanks! :smile: It's a cool project, I'd be happy to contribute to it. As an aside, I made a zeplin account to access the docs, but I don't think I can view them; it's saying that I need an invitation.

@Gregoor I think I got it, but just to make sure I'm on the right page, am I correct in assuming:

  1. The sign up input will always be visible
  2. The call to subscribeToNewsletter in api.ts will be the only interaction made with the backend. Other than that I'm just creating a component to handle this input, checking if it's valid, and calling subscribeToNewsletter if so. Users can subscribe multiple times through this page as long as the email is valid.

@jkmdev 1. Yes-ish. With the new profile experience coming, we'll know when a user has already signed up and will be able to hide it for them. But until that's landed, let's assume it's always displayed

  1. Exactly. On the backend we make sure that the user doesn't subscribe multiple times.

@jkmdev I'm happy to add you to the Zeplin instance, just need an email. :) If you feel more comfortable sending that to me individually, send to [email protected] -- excited to have you helping out!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mikehenrty picture mikehenrty  Â·  3Comments

ftyers picture ftyers  Â·  4Comments

selimsumlu picture selimsumlu  Â·  3Comments

kenrick95 picture kenrick95  Â·  4Comments

jankeromnes picture jankeromnes  Â·  3Comments