Commitlint: False positives when using the slash symbol ("/") in scope

[yenbekbay]

If you include the slash symbol (/) in the scope of a commit message, subject-empty and type-empty rules start throwing errors.

Current Behavior

For the commit message feat(components/Component): subject, I am currently getting the following output:

> commitlint -e

⧗   input: feat(components/Component): subject
✖   message may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   found 2 problems, 0 warnings

Expected Behavior

The commit message feat(components/Component): subject should pass.

Affected packages

Not sure.

Possible Solution

Not sure.

Steps to Reproduce (for bugs)

1. Stage any changes.
2. Commit the changes with the message that has a slash in the scope – e.g. feat(components/Component): subject
3. Run commitlint -e

commitlint.config.js

module.exports = {
  extends: ['@anvilabs/commitlint-config'],
};

Context

Can't use scopes with slashes in them.

Your Environment

| Executable | Version |
| ---: | :--- |
| commitlint --version | 6.0.2 |
| git --version | 2.16.1 |
| node --version | 9.4.0 |

[marionebl]

Probably a bug with conventional-commits-parser, will investigate.

[jiffybank]

Having the same issue with commas in scopes with recent releases. Works in v5.2.3, breaks in v5.2.4.

[marionebl]

Fixed via 6.1.0. Let me know if you still run into problems!

λ commitlint -v
6.1.0

λ echo "feat(components/component): subject" | commitlint
⧗   input: feat(components/component): subject
✔   found 0 problems, 0 warnings

λ echo "feat(components, component): subject" | commitlint
⧗   input: feat(components, component): subject
✔   found 0 problems, 0 warnings

[Stupidism]

@marionebl It's happening again and it's different. Example repo is here.

Looks like there's an extra new-line before my commit message:

➜  cra-rewired-starter git:(master) ✗ gc -m "feat(store/modules): add runtime"
husky > npm run -s precommit (node v8.11.1)

 ✔ Running tasks for {src,config}/**/*.{js,jsx,json}
 ↓ Running tasks for src/**/*.{css,less} [skipped]
   → No staged files match src/**/*.{css,less}
husky > npm run -s commitmsg (node v8.11.1)

⧗   input:
feat(store/modules): add runtime

✖   message may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   scope may not be empty [scope-empty]
✖   found 3 problems, 0 warnings

without slash:

➜  cra-rewired-starter git:(master) ✗ gc -m "feat(store-modules): add runtime"
husky > npm run -s precommit (node v8.11.1)

 ✔ Running tasks for {src,config}/**/*.{js,jsx,json}
 ↓ Running tasks for src/**/*.{css,less} [skipped]
   → No staged files match src/**/*.{css,less}
husky > npm run -s commitmsg (node v8.11.1)

⧗   input: feat(store-modules): add runtime
✔   found 0 problems, 0 warnings

version:

➜  cra-rewired-starter git:(master) ✗ node -v
v8.11.1
➜  cra-rewired-starter git:(master) npm -v
6.0.0
➜ cra-rewired-starter git:(master) ✗ grep 'version' node_modules/@commitlint/cli/package.json
    "type": "version",
  "version": "6.2.0",

cli-test:

➜  cra-rewired-starter git:(master) ✗ echo "feat(components, component): subject" | ./node_modules/.bin/commitlint
⧗   input: feat(components, component): subject
✔   found 0 problems, 0 warnings

➜  cra-rewired-starter git:(master) ✗ echo "feat(components/component): subject" | ./node_modules/.bin/commitlint
⧗   input: feat(components/component): subject
✔   found 0 problems, 0 warnings

[Stupidism]

@marionebl Did you see this? Do I need to submit a new issue?