Colly: Suggestion: Use httptest instead of manually running HTTP server
Currently there is code in the tests manually running a HTTP server to run test against, this is what the net/http/httptest package is meant to be used for.
peterhellberg
All 3 comments
You're right, it would be a better solution. Would you like to work on this?
asciimoo
on 5 Jan 2018
Yes, I've used *httptest.Server in a few projects before so there shouldn't be any surprises…
I can take a look at making this change later, but first I'm going to visit my grandmother 😃
peterhellberg
on 5 Jan 2018
👍3
😄1
Implemented: 132289a
Thank you!
asciimoo
on 6 Jan 2018
Was this page helpful?
0 / 5 - 0 ratings
Related issues
CrazyMouse
·
3Comments
K4N0
·
6Comments
0verbyte
·
5Comments
dnlo
·
4Comments
zplzpl
·
5Comments
Most helpful comment
Yes, I've used
*httptest.Serverin a few projects before so there shouldn't be any surprises…I can take a look at making this change later, but first I'm going to visit my grandmother 😃