Collect: Simplify version parsing code and ensure that different tag structures won't cause a crash

Created on 7 Mar 2020  路  2Comments  路  Source: getodk/collect

See https://github.com/opendatakit/collect/pull/3685#issuecomment-595494561 for suggested approach. I think that by first handling the beta version suffix and then splitting on the first -, there will no longer be a crash risk but this should be added to the tests (e.g. my-cool-version or 777 as versions).

help wanted
Source
picture lognaturel

Most helpful comment

@shobhitagarwal1612 nope! It might seem unrelated but we added test cases to cover this.

picture seadowg on 8 May 2020
👍2

All 2 comments

I think that this issue was closed by mistake in #3777.

shobhitagarwal1612 picture shobhitagarwal1612 on 8 May 2020

@shobhitagarwal1612 nope! It might seem unrelated but we added test cases to cover this.

seadowg picture seadowg on 8 May 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mmarciniak90 picture mmarciniak90  路  5Comments
jsoppela picture jsoppela  路  4Comments
lognaturel picture lognaturel  路  3Comments
grzesiek2010 picture grzesiek2010  路  5Comments
rcovane picture rcovane  路  3Comments