Collect: Collect tries to send all forms even if error occurred precluding to continue sending

[mmarciniak90]

Software and hardware versions

Collect v1.13 and earlier

Problem description

Collect tries to send all forms even if error occurred precluding to continue sending

Steps to reproduce the problem

1. User sends a lot of forms
2. Error occurred (need to check few error types)
3. User is informed about error after sending all forms

Example of real use case:

1. User uses ODK Aggregate server
2. User sends 1000 forms which have declared google sheets <submission action="https://docs.google.com/spreadsheets/d/***/edit?usp=sharing" method="form-data-post"/>

3. Error occurred
   

4. User need to wait wait a few minutes because Collect tries to send all forms

Expected behavior

• Sending process should be stopped after the first error

[TheNerdyFeline]

@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @TheNerdyFeline! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

[getodk-bot]

Hello @TheNerdyFeline, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[ayush13mishra]

@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @ayush13mishra! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

[ayush13mishra]

@opendatakit-bot unclaim

[breakbusyloop]

@mmarciniak90 is there an easy way to get that many forms onto a device for testing this repro? Do you have a .zip of forms that I can download to use in testing?

[mmarciniak90]

@OpenDataNerd yes, you can copy data from this zip backup1249.zip

[chidauri]

@opendatakit-bot claim