Collect: Navigation buttons are not visible if user turns them on during filling form

[mmarciniak90]

Software and hardware versions

Verified on Collect v1.11.0
Android 4.1, 4.2, 4.4, 5.1, 6.0, 7.0

Problem description

Navigation buttons are not visible if user turns them on during filling form

Steps to reproduce the problem

1. 'horizontal swipes' option is selected in navigation
2. User starts filling form
3. User opens General Settings
4. User goes to 'User Interface' options
5. User selects 'Use forward/backward buttons'
6. User clicks device back button to return to form
7. User is moved to form but buttons are not visible - user cannot move to other question

Expected behavior

User sees navigation button even if buttons were turned on during filling form.
Also other cases work immediately when navigation option is changed during filling form.

Workaround

Buttons appear when user changes device orientation

Other information

Problem is not visible if 'Don't keep activities' option is turned on in Android Developer options

[grzesiek2010]

@lognaturel
I think there might be even more bugs related to this case when we are able to change settings after opening the form. Do we really need this option there?

[codedsun]

@grzesiek2010 @mmarciniak90 @lognaturel I want to work on this issue.

[codedsun]

@lognaturel Can i work?

[lognaturel]

This is an interesting one. I'm guessing that the option was put there to be able to change things like base maps while filling out a form. That works because the setting is read when the geo widgets are opened, not before. This one fails because the setting is read on form load. @grzesiek2010 in general my sense is that being able to change settings while filling out a form is useful but you're right that there are other issues. I'd prefer to fix the issue than to remove the possibility to change settings while filling out a form. What do you think?

@codedsun a good start might be to see what other settings cause problems. For example, setting the language brings you back to the landing screen which means you lose the data entered so far. I'm sure there are others like this buttons/swipe setting that should be updated when returning to the form. A list of these would be a good start followed by a proposed plan for addressing them coherently.

[grzesiek2010]

@lognaturel yeah definitely it would be good to have such a list to decide what's next... if we have two issues (for example) we can fix them but if we have 10 maybe it's better to consider removing this option.

@codedsun it's a good first step if you want to take this issue.

[lognaturel]

👍 Good point, @grzesiek2010. We'll have to see how many categories of problems there are.

[codedsun]

@grzesiek2010 Assign it to me :+1:

[grzesiek2010]

@codedsun
you can do that by yourself just add a comment:

@opendatakit-bot claim

[codedsun]

@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @codedsun! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

[grzesiek2010]

ooops I thought it doesn't work if it's a quote so:

@opendatakit-bot unclaim

Now it's only yours :smile:

[lognaturel]

Haha, @grzesiek2010, for next time, putting it in backticks works -- @opendatakit-bot claim. 😊

[grzesiek2010]

@codedsun any results? any problems?

[codedsun]

@grzesiek2010 I got my motherboard crashed few weeks ago, then I shifted to the new system. I am getting back to it, sorry for the delay.Will start the work.

[getodk-bot]

Hello @codedsun, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 7 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!

[codedsun]

@opendatakit-bot unclaim

[grzesiek2010]

Nothing new as I can see so I decided to investigate the issue on my own. The answer is: Yes the problem is related only to buttons and other options are well handled when we return from General Settings.

@opendatakit-bot claim