Collect: Lack of altitude and accuracy when we use location

[grzesiek2010]

Software and hardware versions

Collect 1.6.1

Problem description

When we use location and google sheets only latitude and longitude is sent to google sheet. The answer is without altitude and accuracy.

Form for testing:
loc.txt

[lognaturel]

This was probably deliberate but it would be good to know why. @yanokwa?

[yanokwa]

We didn’t add it because the Google Sheets integration was for mapping into Google products and you can’t map if you have all that data in the column. I think it'd be reasonable to add another two columns. One for altitude and another for accuracy.

[sashank27]

@opendatakit-bot claim

[getodk-bot]

Hello @sashank27, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

[aishwarya-sankhla]

@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @aishwarya-sankhla! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

[aishwarya-sankhla]

Could you please guide on how I could reproduce this?

[yanokwa]

It'd help to know what you've tried so far.

The high level steps are

1. Configure Collect to use Google Drive. http://docs.opendatakit.org/collect-connect-google/
2. Rename the form for testing above (https://github.com/opendatakit/collect/issues/1052#issue-231351261) to loc.xml and upload it to your Google Drive.
3. Fill out the form and submit it to Google Sheets.

[aishwarya-sankhla]

I had previously pushed the form using adb but hadn't configured the the Google drive which is why I was not able to reproduce it.But now I'm able to view it.

Could you please tell how to go about this problem?

[yanokwa]

@aishwarya-sankhla What have you tried so far?

[lognaturel]

Great you're able to view the form now @aishwarya-sankhla! I agree it would be helpful to understand what you've tried so far. I do want to give you a warning that there is a pull request open that will modify Google Sheets code quite a bit that will need to be merged before this. You can see it at #1851. Hopefully it will go through testing tomorrow and can be merged then.

After that, you will need to see how latitude and longitude are currently split up into two columns and do the same for accuracy and elevation. You should verify that it works when results are added to an existing spreadsheet that doesn't have accuracy and elevation as well as when a new one is created.

[getodk-bot]

Hello @aishwarya-sankhla, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[brunoguic]

@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @brunoguic! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

[xsteelej]

@opendatakit-bot claim

[getodk-bot]

Hello @xsteelej, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

[xsteelej]

Hi @yanokwa, @lognaturel,

I've managed to get the form from google drive, I had to add:

<?xml version="1.0"?>

To the top of loc.xml (renamed from loc.txt) before it would appear in "Get Blank Form".

I've filled out the form, got a geo location and finalised it. However, I'm not sure how to submit it to Google Sheets? I've tried "Send Finalized Form" but get an error:

"Geo - invalid sheet id".

(I've noticed that this does create an empty "Open Data Kit" folder on my Google Drive).

[brunoguic]

Hi @xsteelej, I had the same problem here some days ago..

My work around was create a new Google Sheet inside the empty "Open Data Kit"; get the shareable url-link from this sheet, and use that link as "Fallback submission URL" on the General Settings -> Server

I hope this enable you continue your development until get some more appropriate answer.

[xsteelej]

Hi @brunoguic,

Thanks, that did work! I've managed to upload the data to a sheet!

[xsteelej]

Hi @yanokwa,

It looks like altitude / accuracy was intentionally removed from the data-Point, I found this comment in
prepareListOfValues:

// Check to see if answer is a location, if so, get rid of accuracy
// and altitude, try to match a fairly specific pattern to determine
// if it's a location [-]#.# [-]#.# #.# #.#

[lognaturel]

👍@brunoguic that's the way I would get the submissions working. You could also add a submission block to the form that sets the URL there (https://opendatakit.github.io/xforms-spec/#form-definition) but for testing I often just override the fallback URL instead.

From @yanokwa: "We didn’t add it because the Google Sheets integration was for mapping into Google products and you can’t map if you have all that data in the column." I think another reasons the accuracy and altitude columns weren't added was because they get closer to the 256 column limit, especially if there are several points collected. But users have asked for it and my sense is that GSheets integration is used for smaller forms. 200+ questions is a big survey.

[ravi808]

@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @ravi808! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

[lognaturel]

Hi @ravi808! Please be sure to look at assignees, tags and conversations before claiming an issue! There's an in progress pull request at #1052 I have unassigned you. If you'd like to talk through some possible issues to take on, please join us at http://slack.opendatakit.org/ in the #collect-code channel. Thanks!

[getodk-bot]

Hello @xsteelej, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 7 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!

[xsteelej]

Awaiting review