Collect: Remove redundant casts

Created on 6 Mar 2017  路  10Comments  路  Source: getodk/collect

There are several redundant casts across the code base leading to compilation warnings that look like this:

/odk/collect/collect_app/src/main/java/org/odk/collect/android/tasks/DownloadFormListTask.java:128: warning: [cast] redundant cast to Element Element xformElement = (Element) xformsElement.getElement(i);

Find all such instances and remove the redundant casts. This should be submitted as a pull request that ONLY makes this change.

good first issue help wanted in progress refactor

Most helpful comment

Hi @lognaturel
I have college work for past few day that's why I haven't completed it.but I will send PR till tomorrow evening. Is it OK for you?
sorry for the inconvenience.

All 10 comments

Can I work on this @lognaturel

@vikasdesale Please do!

I have added PR.Please check @lognaturel.

@vikasdesale you had not removed all the redundant casts , @lognaturel I am working on this Issue assign it as ' in progress '

@lokeshkvn Please give @vikasdesale another day or two in case he would like to take it. It's still his issue until he says he doesn't want it or a few days pass!

Okay 馃憤

Hi @lognaturel
I have college work for past few day that's why I haven't completed it.but I will send PR till tomorrow evening. Is it OK for you?
sorry for the inconvenience.

Hi, if its still open can i work on it ? @lognaturel

@lognaturel
I have identified about 11 typecasts that need to be removed.
I could send a PR.
Should I?

@vikasdesale We should move ahead on this. @lokeshkvn and @shreyasnbhat, you have both had a chance to get some quick wins merged so @Ishmeetsingh97 should go ahead. Thank you!

@Ishmeetsingh97 in your pull request, please describe how you made sure you handled all cases AND how you made sure it had no effect on behavior.

Was this page helpful?
0 / 5 - 0 ratings