Collect: French buttons for Google Drive form download get resized improperly

[lognaturel]

Software and hardware versions

Collect v1.4.14

Problem description

This happens in any language that has very long text for the download button.

There's a similar but less dramatic problem on the Aggregate download blank form screen:

Steps to reproduce the problem

1. Change Collect protocol to Google Drive, Google Sheets in Collect settings
2. Configure the platform settings with a google account that has forms in Drive
3. Change device language to French (Settings > Language and Input > Language)
4. Go to Télécharger un formulaire vierge (download blank form)

Expected behavior

Buttons should not look like that. 😊 I'm not exactly sure what should happen. Perhaps the buttons should have a minimum width.

Note: I'm updating the translation to match the text on the Aggregate form download button. But this doesn't entirely solve the problem.

[Dvik]

Would it be better if the width of the buttons are in a particular ratio like 1:1:2?

[lognaturel]

@Dvik I'm not sure if that's the right ratio (maybe 1:1:1 makes sense?) but the idea of fixed ratios is probably the right one. It'd be great to see it in action if you'd like to submit a pull request.

[Dvik]

Is this change acceptable?
The first one is the old one and the second the new one.

[lognaturel]

That's much better! I think the buttons should all have the same height, what do you think?

[Dvik]

yeah, that's also my concern. trying to do that

[Dvik]

The first one is when ODK Aggregate is chosen as platform and the second one when Drive is selected as platform. Let me know if this works.

[lognaturel]

Looks great! Do make sure it still looks reasonable in English and then I think it's ready for a pull request!

[Dvik]

In English.

Also, in future as a part of the UX changes in GSOC, we should consider using the Bottom Navigation View recently added in the Design Support Library. https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-usage

[lognaturel]

Fantastic.

Make sure to include suggestions like that in your GSoC application!