Collect: Move all strings in Collect into strings.xml

[getodk-bot]

Issue by mitchellsundt
_Thursday Jul 09, 2015 at 19:24 GMT_
_Originally opened as https://github.com/opendatakit/opendatakit/issues/842 (0 comment(s))_

---

Originally reported on Google Code with ID 841

The Collect code base is littered with non-localized strings. It'd be great if these
strings could all be moved to strings.xml

Reported by [email protected] on 2013-06-11 22:00:48

[lognaturel]

In Android Studio, run Hardcoded Text and Hardcoded Strings inspections by going to Analyze > Run Inspection By Name... and using autocomplete.

[mapkon]

Is the issue being worked on?

[lognaturel]

@mapkon No, it's all yours!

[mapkon]

OK thanks

[mapkon]

It appears that this is going to touch multiple files. Given the recent discussion regarding keeping commits small, I am not sure how to proceed with this. Should all the strings be internalized and submitted at once or should we go package by package (or file by file even)?

[lognaturel]

Great question, @mapkon. I'd like to hear @batkinson's opinion on this one.

[batkinson]

@mapkon I think as long as it is easy to review, you should be good. Normally, when I do this type of thing I work on a branch and commit after every file I modify (and test after). When the strings start touching a lot of code, that's when I'm a little more conservative. For example, while the inspection support can be super-useful, it also has caused me troubles by renaming things it shouldn't. This is another reason I would go step-wise. It's easier to review (and reference) if the commits are limited in scope.

[mapkon]

Thanks a bunch. I will go file by file. That should guarantee a plethora of commits, making me look slightly busier than I should :)